Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123867
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: [PHP-DEV] Add bcdivmod() to BCMath
In-Reply-To: <CADyq6s+V9Q9-EWtJHidGmPEh2F+BoHG3tJ_p35X5tdNXWh1prQ@mail.gmail.com>
Date: Wed, 26 Jun 2024 21:40:45 +0900
Cc: Benjamin Morel <benjamin.morel@gmail.com>,
 Barney Laurance <barney@barneylaurance.uk>,
 php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <EEEBA43D-A77A-48A5-9670-5AE54CF63775@sakiot.com>
References: <190506515d4.f695d014203438.1450648485347018411@barneylaurance.uk>
 <98CEBD66-4E2C-4CB8-8792-A4AEF9982E41@sakiot.com>
 <CAG9XoMR_60y5WAOARLJc8z2-5AFcEHmNx4L6dV_QF4ETFSijww@mail.gmail.com>
 <CADyq6s+V9Q9-EWtJHidGmPEh2F+BoHG3tJ_p35X5tdNXWh1prQ@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
From: saki@sakiot.com (Saki Takamachi)

Hi Marco, Benjamin,

> As for tuple vs reference, I think the general direction is to move =
away from references as much as possible, and AFAIK references actually =
make things harder for IDEs and static analysis tools, whereas the tuple =
syntax array{string, string} is well understood at least by PhpStorm, =
Psalm and PHPStan, which can correctly type the function's return value =
in their stubs.

I see, I agree. This problem seems to be solved by using PHPDoc.

> I'm wondering if an array vs an object allocation makes a difference =
here, or if the amount of `bcdivmod()` execution dwarfs this sort of =
concern?
>=20
> Thinking:
>=20
> ```php
> $result =3D \bcdivmod('123', '2');
>=20
> echo $result->quotient; // '61'
> echo $result->remainder; // '1'
> ```
>=20
> No idea if that's relevant, so I'm throwing it in the room.

BCMath is significantly faster in master, so its cost may have a =
significant impact.

For reference, here is a speed comparison with 8.3 on my env. The =
benchmark used is the code from ext-decimal, which is often introduced =
in the context of "BCMath is slow=E2=80=9D. The unit of all measurement =
results is "seconds".
https://php-decimal.github.io/#performance

8.3
- add int: 3.7771
- add string: 3.0387
- sub int: 3.491
- sub string: 3.0248
- mul int: 5.3318
- mul string: 5.7315
- div int: 10.6659
- div string: 25.762

Master
- add int: 1.72
- add string: 1.4444
- sub int: 1.763
- sub string: 1.4745
- mul int: 2.2038
- mul string: 2.0621
- div int: 2.8515
- div string: 2.9411

Regards,

Saki=