Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123846
Subject: Re: [PHP-DEV] Add $this return type
To: internals@lists.php.net
References: <CAAGC1OsCEgqhSNDCZaJ3tK_EEQwPHvqs+jsL3XRY3KeAhLRkGg@mail.gmail.com>
 <CAAwdEzD2jtiBLcW6anQP4R7X4jBznwBX9B0pfbzavUsz+qPEZg@mail.gmail.com>
 <CAAGC1OvDeB16Vmq_VXxUmTOKv6etsNGcW7_cMSpxoXJG2o3z7w@mail.gmail.com>
Message-ID: <667B35B7.4070902@adviesenzo.nl>
Date: Tue, 25 Jun 2024 23:25:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAAGC1OvDeB16Vmq_VXxUmTOKv6etsNGcW7_cMSpxoXJG2o3z7w@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------070609040009040800060800"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------070609040009040800060800
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 25-6-2024 19:53, radar3301 wrote:

> Sebastian Bergmann said:
>> [snip] please not "$this" as the name for a type.
>> Off the top of my head, I think that "same" could make sense.
> My primary vote would still be for "$this" as explained above, but I
> could potentially be persuaded
> to switch to "this" or "same" as alternatives if the dollar-sign is
> too much of a hang-up.

Not a fan of using a variable as a return type. This will cause havoc 
for Tokenizer based static analysis tooling.
Not a fan of the implicit return either.

Also don't really see the need as there is the `static` return type already.

--------------070609040009040800060800
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 25-6-2024 19:53, radar3301 wrote:<br>
    </div>
    <br>
    <blockquote
cite="mid:CAAGC1OvDeB16Vmq_VXxUmTOKv6etsNGcW7_cMSpxoXJG2o3z7w@mail.gmail.com"
      type="cite">
      Sebastian Bergmann said:
      <blockquote type="cite">
        <pre wrap="">[snip] please not "$this" as the name for a type.
Off the top of my head, I think that "same" could make sense.
</pre>
      </blockquote>
      <pre wrap="">My primary vote would still be for "$this" as explained above, but I
could potentially be persuaded
to switch to "this" or "same" as alternatives if the dollar-sign is
too much of a hang-up.
</pre>
    </blockquote>
    <br>
    Not a fan of using a variable as a return type. This will cause
    havoc for Tokenizer based static analysis tooling.<br>
    Not a fan of the implicit return either.<br>
    <br>
    Also don't really see the need as there is the `static` return type
    already.<br>
  </body>
</html>

--------------070609040009040800060800--