Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123843
Precedence: bulk
MIME-Version: 1.0
References: <190506515d4.f695d014203438.1450648485347018411@barneylaurance.uk>
 <98CEBD66-4E2C-4CB8-8792-A4AEF9982E41@sakiot.com> <CAG9XoMR_60y5WAOARLJc8z2-5AFcEHmNx4L6dV_QF4ETFSijww@mail.gmail.com>
In-Reply-To: <CAG9XoMR_60y5WAOARLJc8z2-5AFcEHmNx4L6dV_QF4ETFSijww@mail.gmail.com>
Date: Tue, 25 Jun 2024 22:28:33 +0200
Message-ID: <CADyq6s+V9Q9-EWtJHidGmPEh2F+BoHG3tJ_p35X5tdNXWh1prQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Add bcdivmod() to BCMath
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: Saki Takamachi <saki@sakiot.com>, Barney Laurance <barney@barneylaurance.uk>, 
	php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a6f242061bbcbef6"
From: ocramius@gmail.com (Marco Pivetta)

--000000000000a6f242061bbcbef6
Content-Type: text/plain; charset="UTF-8"

Hey Benjamin,

On Tue, 25 Jun 2024 at 22:24, Benjamin Morel <benjamin.morel@gmail.com>
wrote:

>
> I predicted this would probably be on the agenda. Another idea is to pass
>> arguments by reference, like in `exec()`.
>>
>> Personally, I find something like a tuple easier to use. However, without
>> generics, all we know is that the return type is an array, which may be
>> inconvenient in terms of IDE completion, etc.
>>
>
> As for tuple vs reference, I think the general direction is to move away
> from references as much as possible, and AFAIK references actually make
> things harder for IDEs and static analysis tools, whereas the tuple syntax
> array{string, string} is well understood at least by PhpStorm, Psalm and
> PHPStan, which can correctly type the function's return value in their
> stubs.
>

Full ack on this.

I'm wondering if an array vs an object allocation makes a difference here,
or if the amount of `bcdivmod()` execution dwarfs this sort of concern?

Thinking:

```php
$result = \bcdivmod('123', '2');

echo $result->quotient; // '61'
echo $result->remainder; // '1'
```

No idea if that's relevant, so I'm throwing it in the room.

Marco Pivetta

https://mastodon.social/@ocramius

https://ocramius.github.io/

--000000000000a6f242061bbcbef6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hey Benjamin,</div><br><div class=3D"gmai=
l_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, 25 Jun 2024 at 22:24=
, Benjamin Morel &lt;<a href=3D"mailto:benjamin.morel@gmail.com">benjamin.m=
orel@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><br><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex">I predicted this would probably be on =
the agenda. Another idea is to pass arguments by reference, like in `exec()=
`.<br><br>Personally, I find something like a tuple easier to use. However,=
 without generics, all we know is that the return type is an array, which m=
ay be inconvenient in terms of IDE completion, etc.<br></blockquote><div><b=
r></div><div>As for tuple vs reference, I think the general direction is to=
 move away from references as much as possible, and AFAIK references actual=
ly make things harder for IDEs and static analysis tools, whereas the tuple=
 syntax array{string, string} is well understood at least by PhpStorm, Psal=
m and PHPStan, which can correctly type the function&#39;s return value in =
their stubs.</div></div></div></blockquote><div><br></div><div>Full ack on =
this.</div><div><br></div><div>I&#39;m wondering if an array vs an object a=
llocation makes a difference here, or if the amount of `bcdivmod()` executi=
on dwarfs this sort of concern?</div><div><br></div><div>Thinking:</div><di=
v><br></div><div>```php</div><div>$result =3D \bcdivmod(&#39;123&#39;, &#39=
;2&#39;);</div><div><br></div><div>echo $result-&gt;quotient; // &#39;61=
9;</div><div>echo $result-&gt;remainder; // &#39;1&#39;</div><div>```</div>=
<div><br></div><div>No idea if that&#39;s relevant, so I&#39;m throwing it =
in the room.</div><div><br clear=3D"all"><div><div><div dir=3D"ltr" class=
=3D"gmail_signature"><div dir=3D"ltr">Marco Pivetta <br><br><a href=3D"http=
s://mastodon.social/@ocramius" target=3D"_blank">https://mastodon.social/@o=
cramius</a><br><br><a href=3D"https://ocramius.github.io/" target=3D"_blank=
">https://ocramius.github.io/</a><br></div></div></div></div>=C2=A0</div></=
div></div>

--000000000000a6f242061bbcbef6--