Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123841
Precedence: bulk
MIME-Version: 1.0
References: <190506515d4.f695d014203438.1450648485347018411@barneylaurance.uk> <98CEBD66-4E2C-4CB8-8792-A4AEF9982E41@sakiot.com>
In-Reply-To: <98CEBD66-4E2C-4CB8-8792-A4AEF9982E41@sakiot.com>
Date: Tue, 25 Jun 2024 22:23:56 +0200
Message-ID: <CAG9XoMR_60y5WAOARLJc8z2-5AFcEHmNx4L6dV_QF4ETFSijww@mail.gmail.com>
Subject: Re: [PHP-DEV] Add bcdivmod() to BCMath
To: Saki Takamachi <saki@sakiot.com>
Cc: Barney Laurance <barney@barneylaurance.uk>, php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000008652d061bbcaec5"
From: benjamin.morel@gmail.com (Benjamin Morel)

--00000000000008652d061bbcaec5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

>
> I see, I understand.
>
> But I don't think that's wise. For example, if we reversed the order of
> the div and mod, there would be no cache and we wouldn't get the speed
> boost. (Or does it cache the quotient as well?)
>

I don't think the cache is a good idea either, for the reasons you
mentioned.

I predicted this would probably be on the agenda. Another idea is to pass
> arguments by reference, like in `exec()`.
>
> Personally, I find something like a tuple easier to use. However, without
> generics, all we know is that the return type is an array, which may be
> inconvenient in terms of IDE completion, etc.
>

As for tuple vs reference, I think the general direction is to move away
from references as much as possible, and AFAIK references actually make
things harder for IDEs and static analysis tools, whereas the tuple syntax
array{string, string} is well understood at least by PhpStorm, Psalm and
PHPStan, which can correctly type the function's return value in their
stubs.

=E2=80=94 Benjamin

--00000000000008652d061bbcaec5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">I see, I understand.<br>
<br>
But I don&#39;t think that&#39;s wise. For example, if we reversed the orde=
r of the div and mod, there would be no cache and we wouldn&#39;t get the s=
peed boost. (Or does it cache the quotient as well?)<br></blockquote><div><=
br></div><div>I don&#39;t think the cache is a good idea either, for the re=
asons you mentioned.</div><div><br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex">I predicted this would probably be on the agenda. Another i=
dea is to pass arguments by reference, like in `exec()`.<br><br>Personally,=
 I find something like a tuple easier to use. However, without generics, al=
l we know is that the return type is an array, which may be inconvenient in=
 terms of IDE completion, etc.<br></blockquote><div><br></div><div>As for t=
uple vs reference, I think the general direction is to move away from refer=
ences as much as possible, and AFAIK references actually make things harder=
 for IDEs and static analysis tools, whereas the tuple syntax array{string,=
 string} is well understood at least by PhpStorm, Psalm and PHPStan, which =
can correctly type the function&#39;s return value in their stubs.</div><di=
v><br></div><div>=E2=80=94 Benjamin<br></div></div></div>

--00000000000008652d061bbcaec5--