Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123825
Feedback-ID: id5114917:Fastmail
Message-ID: <b922b56a-b0e0-454b-a1ec-6f981f66795a@rwec.co.uk>
Date: Tue, 25 Jun 2024 17:03:02 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4
To: internals@lists.php.net
References: <bw20I5b7ly3lSbI-2Bv3kfrfTVJbDo5RhwBiQa1PEwuLjprDJWptPajLiaialj1RLVKu7z1j0MofJUhhRVtzT_5i2E11oKeQx_VMUxnKhUE=@gpb.moe>
 <CADyq6sLuz3430TRMu8cSh5_x57UBaWA8v4sr_c+OgUSjn-otBQ@mail.gmail.com>
Content-Language: en-GB
In-Reply-To: <CADyq6sLuz3430TRMu8cSh5_x57UBaWA8v4sr_c+OgUSjn-otBQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: imsop.php@rwec.co.uk ("Rowan Tommins [IMSoP]")

On 25/06/2024 16:27, Marco Pivetta wrote:
>
>  * `uniqid()`, in my case (XKCD 1172) is largely used for quickly 
> generating a semi-random string for test purposes: a suitable 
> replacement PRNG implementation would be welcome. Even refactoring 
> with tools like Rector will lead to quite messy code, or added 
> dependencies. IMO fine to get rid of **this specific implementation**, 
> if a safe function is provided, such as `random_ascii_string()` or 
> such (dunno, just a hint)


Agreed, the implementation is weird, but nothing else matches the 
convenience to just get "some random printable bytes". As of PHP 8.3, we 
finally have Random\Randomizer::getBytesFromString, but the comparison 
is pretty stark:

$foo = uniqid();
$foo = (new 
\Random\Randomizer)->getBytesFromString('abcdefghijklmnopqrstuvwxyz0123456789', 
13);

Alternatively, you have the shorter but slightly cryptic:

$foo = bin2hex(random_bytes(6));

Then again, if you _actually_ want it to be unique, rather than random, 
those aren't the right replacements anyway.

I'd love to replace uniqid() with *something*, but I don't think we have 
that thing yet.


-- 
Rowan Tommins
[IMSoP]