Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123822
Precedence: bulk
MIME-Version: 1.0
References: <90AAEBAA-30DC-40B4-AEBD-D4958753324A@sakiot.com> <fd2fb926-2d36-445b-92f7-d48b7b18076a@app.fastmail.com>
In-Reply-To: <fd2fb926-2d36-445b-92f7-d48b7b18076a@app.fastmail.com>
Date: Tue, 25 Jun 2024 17:52:14 +0200
Message-ID: <CAG9XoMSVrL2_+H70Mu20f7wJCEjoPBdC7tJWw+o97k1Y_KMr5w@mail.gmail.com>
Subject: Re: [PHP-DEV] Add bcdivmod() to BCMath
To: Larry Garfield <larry@garfieldtech.com>, Saki Takamachi <saki@sakiot.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a3aa36061bb8e39c"
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000a3aa36061bb8e39c
Content-Type: text/plain; charset="UTF-8"

Hi,

I've been working on improving performance of BCMath lately, and I found
> that I can get the div and mod in one calculation. This is obviously faster
> than calculating it twice separately.
>
> Do you think there's a demand for this feature?
>
> e.g.
> ```
> [$quot, $rem] = bcdivmod('123', '2');
> // $quot is '61', $rem is '1'
> ```
>
> The naming and return value scheme is inspired by Python and Ruby.
>
> Of course, if this is added, equivalent functionality will be added to the
> Number class.
>
> Regards,
>
> Saki
>

I would definitely use this in brick/math:

https://github.com/brick/math/blob/0.12.1/src/Internal/Calculator/BcMathCalculator.php#L43-L49


> This isn't something I'm likely to ever use as I don't do complex math
> much, but it seems like a reasonable optimization for those that do.  No
> objection.
>
> My only question is the pseudo-tuple return, which is rarely used in PHP
> (although I've used it myself, I think exactly once), and I think this
> would be the first use of it in a built in library.  (I may be wrong on
> that.)  I don't have a particular alternative to suggest, just flagging
> that as the main part that could warrant discussion.
>
> --Larry Garfield
>

It's actually already used by gmp_div_qr(), so +1 from me.

- Benjamin

--000000000000a3aa36061bb8e39c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div><br></div><div class=3D"gmail_quote"><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex">I&#39;ve been working on im=
proving performance of BCMath lately, and I found that I can get the div an=
d mod in one calculation. This is obviously faster than calculating it twic=
e separately.<br><br>Do you think there&#39;s a demand for this feature?<br=
><br>e.g.<br>```<br>[$quot, $rem] =3D bcdivmod(&#39;123&#39;, &#39;2&#39;);=
<br>// $quot is &#39;61&#39;, $rem is &#39;1&#39;<br>```<br><br>The naming =
and return value scheme is inspired by Python and Ruby.<br><br>Of course, i=
f this is added, equivalent functionality will be added to the Number class=
.<br><br>Regards,<br><br>Saki<br></blockquote><div><br></div><div>I would d=
efinitely use this in brick/math:</div><div><br></div><div><a href=3D"https=
://github.com/brick/math/blob/0.12.1/src/Internal/Calculator/BcMathCalculat=
or.php#L43-L49">https://github.com/brick/math/blob/0.12.1/src/Internal/Calc=
ulator/BcMathCalculator.php#L43-L49</a></div><div>=C2=A0</div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex">
This isn&#39;t something I&#39;m likely to ever use as I don&#39;t do compl=
ex math much, but it seems like a reasonable optimization for those that do=
.=C2=A0 No objection.<br>
<br>
My only question is the pseudo-tuple return, which is rarely used in PHP (a=
lthough I&#39;ve used it myself, I think exactly once), and I think this wo=
uld be the first use of it in a built in library.=C2=A0 (I may be wrong on =
that.)=C2=A0 I don&#39;t have a particular alternative to suggest, just fla=
gging that as the main part that could warrant discussion.<br>
<br>
--Larry Garfield<br></blockquote><div><br></div><div>It&#39;s actually alre=
ady used by=C2=A0gmp_div_qr(), so=C2=A0+1 from me.</div><div><br></div><div=
>- Benjamin</div><div>=C2=A0</div></div></div>

--000000000000a3aa36061bb8e39c--