X-Mailer: iPhone Mail (21F90) From: php-lists@koalephant.com (Stephen Reay) --Apple-Mail-BDDA40C0-E437-4125-9EF5-FBB285DD4D40 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
=

Sent from my iPhone

On 24 Jun 2024, at 23:43, Matthew Weier O'Phinney <mweieroph= inney@gmail.com> wrote:

=EF=BB=BF

On Mon, Ju= n 24, 2024 at 10:08=E2=80=AFAM Nicolas Grekas <nicolas.grekas+php@gmail.com> wrote:

Le mer. 5 juin 2024 =C3=A0 10:18, Benjamin Au=C3=9Fenhofe= r <kontakt@beber= lei.de> a =C3=A9crit :

On Wed, May 22, 2024 at 9= :22=E2=80=AFAM Benjamin Au=C3=9Fenhofer <kontakt@beberlei.de> wrote:
The vote for the R= FC #[\Deprecated] attribute is now open:

https://wiki.php.net/rf= c/deprecated_attribute

Voting will close on Wednesday 5th June, 0= 8:00 GMT.

The #[\Deprecated] attribute has been acce= pted with 23 (Yes) to 6 (No) votes, 79%.

The secondary vote to include Deprecated:= :$since has also been accepted with 22 (Yes) to 1 (No) votes, 96%.

Thank you to everyon= e for voting!

T= im will finalize the implementation PR now and work on its merge in the upco= ming days.

Hi Benjamin,=
<= br>
<= div class=3D"gmail_quote">
<= div dir=3D"ltr">The vote for the RFC #[\Deprecated] attribute is now op= en:

https://wiki.php.net/rfc/deprecated_attribute

Voting wil= l close on Wednesday 5th June, 08:00 GMT.

The #[\Dep= recated] attribute has been accepted with 23 (Yes) to 6 (No) votes, 79%.
=

The secon= dary vote to include Deprecated::$since has also been accepted with 22 (Yes)= to 1 (No) votes, 96%.

Thank you to everyone for voting!

Tim will finalize the implementation PR now a= nd work on its merge in the upcoming days.

Since the vote passed, we're discussing how we might use the a= ttribute in Symfony.

2 things on the topic:

1/ We're wondering about using it at the class level despite the miss= ing Attribute::TARGET_CLASS.&nbs= p;ReflectionAttribute does allow reading attributes without checking these flags and we might leverage this capability to make our DebugClassLoader able to inspect=20 those at the class level.

<= br>

Would you consider addi= ng Attribute::TARGET_CLASS in 8.4 already? It would just make sense to me. We don't need the=20 engine to do anything about deprecated classes ever since all we need in userland is a class-loader that checks for the attribute. Keeping the=20 engine simpler and empowering userland with maximum flexiblity FTW. I'm=20 up for a quick RFC if the consensus is this needs one.

2/ About the "since" parameter, we're going to standardize a= round a package+version string, e.g.

#[Deprecated(since: "symfony/yaml v7.2"]

I'm sharing this hoping this can spread outside of Symfony's boundary=20 because I think this would be a very useful practice that'd allow=20 building nice reporting tools.

Personally, I'd prefer t= he "since" format to mimic the notation that Composer uses on the CLI when s= pecifying a package with a constraint: "symfony/yaml:7.2.0". This can be par= sed easily, and won't suffer from having arbitrary spacing and version namin= g prefixes.

(Still would prefer a "scheduledR= emoval" field, as knowing when it was deprecated is far less interesting tha= n knowing when it will be removed. Yes, I can assume the next major version,= but what if it's major version + 1? What if a project allows removals durin= g minor releases? Knowing what version it will be removed in makes it far ea= sier to understand what will happen when I upgrade next.)

Matthew Weier O'Phinneymweierophinne= y@gmail.com
https://m= wop.net/

he/him

If you're marking a piece of code in a pro= ject as deprecated, why does the deprecation notice need to re-specify the p= ackage the code is in? Wouldn't a regular version string be sufficient?

= --Apple-Mail-BDDA40C0-E437-4125-9EF5-FBB285DD4D40--