Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123775
Precedence: bulk
MIME-Version: 1.0
References: <eb3f59cc-3ed8-461a-a3a4-f6ba10ed31e1@scriptfusion.com>
In-Reply-To: <eb3f59cc-3ed8-461a-a3a4-f6ba10ed31e1@scriptfusion.com>
Date: Mon, 24 Jun 2024 09:59:27 +0300
Message-ID: <CAAwdEzB0b9hpqr03DLOtZVkSL6c7A0P7tb=iwZ7BGH5RDC_sRA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Static class
To: Bilge <bilge@scriptfusion.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000269c96061b9d535a"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000269c96061b9d535a
Content-Type: text/plain; charset="UTF-8"

On Mon, Jun 24, 2024, 02:15 Bilge <bilge@scriptfusion.com> wrote:

> Hi Internals!
>
> I am pleased to present my first RFC: Static class
> <https://wiki.php.net/rfc/static_class>.
>
>
Hi! and good luck with the RFC.

While I don't use static classes, I can see how this can be used by others.

I worked in big projects that used too many libraries, and when those
libraries have functions.php file, they pile up and loading the composer
autoloader can take a small dent on performance of each request.
Having functions grouped by a class that can autoloader instead of a file
is an advantage that should be spelled out as an use case.



Feedback:

1. I agree that static classes may extend other non-static classes (that
might have some static behavior).
But I think that static classes should be extended only by other static
classes, or at least for the first iteration of these feature.
This should be documented more in the RFC, no matter how it ends up being.
1.1 I think using a static class as a type should be considered an error,
as there will never be instances of it if we consider all child classes
will also be static classes.
Of course, this cannot be an error on php side given the class per file
loading separation.


2. __set_state() is strongly linked to exporting a class instance as a
valid php string, and is used to reconstruct the class instance upon
execution.
Considering we forbid instances, we should not support __set_state(). If
you think otherwise, please share an example how it can be used.

Regards,
Alex

--000000000000269c96061b9d535a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Mon, Jun 24, 2024, 02:15 Bilge &lt;<a href=3D"mailt=
o:bilge@scriptfusion.com" target=3D"_blank" rel=3D"noreferrer">bilge@script=
fusion.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Inter=
nals!<br>
<br>
I am pleased to present my first RFC: Static class <br>
&lt;<a href=3D"https://wiki.php.net/rfc/static_class" rel=3D"noreferrer nor=
eferrer noreferrer" target=3D"_blank">https://wiki.php.net/rfc/static_class=
</a>&gt;.<br>
<br></blockquote></div></div><div dir=3D"auto"><div class=3D"gmail_quote"><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex"></blockquote></div></div><div dir=3D"auto"><b=
r></div><div dir=3D"auto">Hi! and good luck with the RFC.</div><div dir=3D"=
auto"><br></div><div dir=3D"auto">While I don&#39;t use static classes, I c=
an see how this can be used by others.</div><div dir=3D"auto"><br></div><di=
v dir=3D"auto">I worked in big projects that used too many libraries, and w=
hen those libraries have functions.php file, they pile up and loading the c=
omposer autoloader can take a small dent on performance of each request.</d=
iv><div dir=3D"auto">Having functions grouped by a class that can autoloade=
r instead of a file is an advantage that should be spelled out as an use ca=
se.</div><div dir=3D"auto"><br></div><div dir=3D"auto"><br></div><div dir=
=3D"auto"><br></div><div dir=3D"auto">Feedback:</div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">1. I agree that static classes may extend other non=
-static classes (that might have some static behavior).</div><div dir=3D"au=
to">But I think that static classes should be extended only by other static=
 classes, or at least for the first iteration of these feature.</div><div d=
ir=3D"auto">This should be documented more in the RFC, no matter how it end=
s up being.</div><div dir=3D"auto">1.1 I think using a static class as a ty=
pe should be considered an error, as there will never be instances of it if=
 we consider all child classes will also be static classes.</div><div dir=
=3D"auto">Of course, this cannot be an error on php side given the class pe=
r file loading separation.</div><div dir=3D"auto">=C2=A0</div><div dir=3D"a=
uto"><br></div><div dir=3D"auto">2. __set_state() is strongly linked to exp=
orting a class instance as a valid php string, and is used to reconstruct t=
he class instance upon execution.</div><div dir=3D"auto">Considering we for=
bid instances, we should not support __set_state(). If you think otherwise,=
 please share an example how it can be used.</div><div dir=3D"auto"><br></d=
iv><div dir=3D"auto">Regards,</div><div dir=3D"auto">Alex</div><div dir=3D"=
auto"></div></div>

--000000000000269c96061b9d535a--