Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123670
Precedence: bulk
MIME-Version: 1.0
References: <CAPzBOBMidokE3xw251f+_qbCPAyQQRcN1WnyVF0xfuzaPBU3JA@mail.gmail.com>
 <C8BB432C-DE32-4A99-B836-BE9384E3A392@gmail.com>
In-Reply-To: <C8BB432C-DE32-4A99-B836-BE9384E3A392@gmail.com>
Date: Wed, 19 Jun 2024 10:29:23 +0200
Message-ID: <CAPzBOBPL76oHaBW1PYjGUWY2WZX-7iTuHcWC17=AG2DenQp0fA@mail.gmail.com>
Subject: Re: [PHP-DEV] Renaming "strict types" to "scalar type coercion"
To: Claude Pache <claude.pache@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: landers.robert@gmail.com (Robert Landers)

On Tue, Jun 18, 2024 at 9:18=E2=80=AFPM Claude Pache <claude.pache@gmail.co=
m> wrote:
>
> Hi,
>
> > One thing is clear is that "strict types" may be a bit of poor word
> > choice and gives people a false sense of security that it is "safe" or
> > "more correct" when this obviously isn't true. Thus, I'd like to
> > propose, for PHP 9, simply renaming it from strict_types to
> > scalar_type_coercion and flipping the value:
> >
> > <?php declare(strict_types=3D1);
> >
> > to
> >
> > <?php declare(scalar_type_coercion=3D0);
>
> This not better. Even with `declare(scalar_type_coercion=3D0)`, there wil=
l be scalar type conversions between string and int/float when you add nume=
ric strings or when you concatenate a string with an int.

This is a really good point and worth thinking about. I kinda like
Rowan's suggestion of scalar_args with a usage of string values
instead of integers.

>
> IMO, the real problem with the current name, is that there is no clue tha=
t this directive is specifically about arguments and return values in funct=
ion/method calls.

Yes. This is kinda what I was hoping to address, but like you said,
the name I suggested didn't really capture the semantics either. :D

>
> > Perhaps it might even be worth adding a secondary vote to flip the
> > default, such that if you want to "old" behavior back:
> >
> > <?php declare(scalar_type_coercion=3D1);
>
> That would force to edit thousands of files, ... for exactly zero gain. H=
ave you heard about the Red Queen's race?

This is a pretty simple search-and-replace, so I don't think it would
be hard to update. That being said, there still needs to be a
deprecation strategy that makes sense. As to it being "zero gain,"
words have meaning and choosing the right ones (even if it is years
later) can sometimes be completely worth it and even have monetary
gains.

>
> Moreover, there are many places where it is not possible to add such a de=
claration. For instance, `array_map(...)`, etc., always use `strict_types=
=3D0` when invoking the callback. Changing that would also be a big BC brea=
k.
>
> =E2=80=94Claude


Robert Landers
Software Engineer
Utrecht NL