Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123631
Message-ID: <67d37d56-625f-4f80-805d-a5db2d3807bb@bastelstu.be>
Date: Sun, 16 Jun 2024 12:56:46 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and
 make it an Enum
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: Saki Takamachi <saki@sakiot.com>, Jorg Sowa <jorg.sowa@gmail.com>,
 php internals <internals@lists.php.net>
References: <9zUVZKaEYixjCLLhviQPYFQtSAEhsRMWL6xbKeogzAGsH-STebN9JqJxITAPVfdKTNu7gEs_m77OkIcOzaiscoajx8Hp8VWRKkhTTCPkGko=@gpb.moe>
 <6E690732-8BED-4A01-8385-648E7CEDFD9F@sakiot.com>
 <70f63dd2e0ba7959a9e3bb7fa68ce14a@bastelstu.be>
 <CJrCSLTp-erzdhSRTrFn2Ss0AoEpkkhqh7fnUrXgHyMfgNPkwXhpSeGsKdhV_ycUIqWhJWpWOxI0W8XGprR_O8iqSrVVWoBNiUUFMaZCNDY=@gpb.moe>
Content-Language: en-US
In-Reply-To: <CJrCSLTp-erzdhSRTrFn2Ss0AoEpkkhqh7fnUrXgHyMfgNPkwXhpSeGsKdhV_ycUIqWhJWpWOxI0W8XGprR_O8iqSrVVWoBNiUUFMaZCNDY=@gpb.moe>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/13/24 03:28, Gina P. Banyard wrote:
> Thank you, I think other than possibly prefixing the NegativeInfinity
> and PositiveInfinity cases with "Towards" I am happy with the content
> of the RFC.

I've discussed this with Saki. In that case the `HalfEven` and `HalfOdd` 
modes would also need to be renamed to `HalfTowardsEven` and 
`HalfTowardsOdd`, resulting in this:

     enum RoundingMode
     {
       case HalfAwayFromZero; // PHP_ROUND_HALF_UP
       case HalfTowardsZero; // PHP_ROUND_HALF_DOWN
       case HalfTowardsEven; // PHP_ROUND_HALF_EVEN
       case HalfTowardsOdd; // PHP_ROUND_HALF_ODD
       case TowardsZero; // PHP_ROUND_TOWARD_ZERO
       case AwayFromZero; // PHP_ROUND_AWAY_FROM_ZERO
       case TowardsNegativeInfinity; // PHP_ROUND_FLOOR
       case TowardsPositiveInfinity; // PHP_ROUND_CEILING
     }

Except for the `AwayFromZero` modes, every mode contains `Towards` and 
especially the `HalfTowardsX` modes are too similar to easily 
distinguish them visually.

Thus we prefer the current state of the RFC where the different modes 
have plenty of hamming distance, while still being sufficiently descriptive.

Best regards
Tim Düsterhus