Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123604
Message-ID: <6ca039db-9774-4a7e-97ba-b82cc3f6609f@bastelstu.be>
Date: Fri, 14 Jun 2024 17:57:11 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Lazy Objects
To: Arnaud Le Blanc <arnaud.lb@gmail.com>
Cc: Nicolas Grekas <nicolas.grekas+php@gmail.com>,
 PHP Internals List <internals@lists.php.net>
References: <CAOWwgpmbq5VRrZQvUXDsKiNK4r6+bFA4VxnjQ_U=h8T9r0o3DA@mail.gmail.com>
 <ab83af79-0669-47dd-a3cb-ab72327ae174@bastelstu.be>
 <CAP1Jc13JWVg99AULgzrGXcoCWJtJZGz+nr_VoyUocw8n5n5sfQ@mail.gmail.com>
 <1118bbcd-a7b4-47bf-bf35-1a36ab4628e1@bastelstu.be>
 <CAP1Jc11vNiazMRL8Y-4NcJhsEkg6kgFNKLymTGfEPYRv114oTA@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAP1Jc11vNiazMRL8Y-4NcJhsEkg6kgFNKLymTGfEPYRv114oTA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/14/24 14:13, Arnaud Le Blanc wrote:
> We have updated the RFC to address your feedback. Please find
> additional answers below.

for some preliminary feedback: I've given the RFC another quick read and 
it already reads *much* better, thank you. The two examples for the two 
strategies were pretty illustrative.

- I noticed a small typo "makeInstanceLazyHost".
- The ORM example uses 'setPropertyValue', I believe it should read 
'setRawPropertyValue'.
- The LazyConnection example uses 'ReflectionLazyObject', should that 
read 'ReflectionLazyObjectFactory'?

I plan to give more detailed feedback at a later point, when i have the 
time to think through your reply and the semantics updated RFC.

Best regards
Tim Düsterhus

PS: Thanks, I hate the example of how readonly properties can already 
change in existing versions :-(