Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123592
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 13 Jun 2024 08:55:31 +0200
Message-ID: <CABEW5qeZkZB_sSAL2ZpbhhT85pA3Wyp4u1x5aLcKrkivTDDurg@mail.gmail.com>
Subject: [PHP-DEV] Follow up of DateTimeException RFC
To: PHP Internals List <internals@lists.php.net>, derick@php.net
Content-Type: multipart/alternative; boundary="000000000000cb62e4061abffcf9"
From: misterdeviling@gmail.com (Vincent Langlet)

--000000000000cb62e4061abffcf9
Content-Type: text/plain; charset="UTF-8"

Hi,

There was an RFC about more appropriate date exceptions
https://wiki.php.net/rfc/datetime-exceptions
implemented in
https://github.com/php/php-src/commit/66a1a911f1d6cd4b89c0bb5577fa77f1d6a2cb96

Looking at PHP example, it updated method return types like
- Datetime::modify
- DatetimeImmutable::modify
- DateInterval::createFromDateString

https://3v4l.org/iSPL9

These methods doesn't seem to return false anymore, but the PHP stub wasn't
updated so the reflection class still consider false as a valid return type
https://3v4l.org/IZXbp.

Is there still case where such method can return FALSE or should we update
the signature of these methods (and maybe some others) ?

Thanks.

--000000000000cb62e4061abffcf9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><br>There was an RFC about more appropriate date ex=
ceptions<div><a href=3D"https://wiki.php.net/rfc/datetime-exceptions">https=
://wiki.php.net/rfc/datetime-exceptions</a><br>implemented in=C2=A0<a href=
=3D"https://github.com/php/php-src/commit/66a1a911f1d6cd4b89c0bb5577fa77f1d=
6a2cb96">https://github.com/php/php-src/commit/66a1a911f1d6cd4b89c0bb5577fa=
77f1d6a2cb96</a></div><div><br></div><div>Looking at PHP example, it update=
d method return types like<br>- Datetime::modify</div><div>- DatetimeImmuta=
ble::modify<br>- DateInterval::createFromDateString<br><br></div><div><a hr=
ef=3D"https://3v4l.org/iSPL9">https://3v4l.org/iSPL9</a><br><br>These metho=
ds doesn&#39;t seem to return false anymore, but the PHP stub wasn&#39;t up=
dated so the reflection class still consider false as a valid return type=
=C2=A0<a href=3D"https://3v4l.org/IZXbp">https://3v4l.org/IZXbp</a>.<br><br=
>Is there still case where such method can return FALSE or should we update=
 the signature of these methods (and maybe some others) ?<br><br>Thanks.</d=
iv></div>

--000000000000cb62e4061abffcf9--