Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123591
Date: Thu, 13 Jun 2024 01:28:21 +0000
To: =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Saki Takamachi <saki@sakiot.com>, Jorg Sowa <jorg.sowa@gmail.com>, php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and make it an Enum
Message-ID: <CJrCSLTp-erzdhSRTrFn2Ss0AoEpkkhqh7fnUrXgHyMfgNPkwXhpSeGsKdhV_ycUIqWhJWpWOxI0W8XGprR_O8iqSrVVWoBNiUUFMaZCNDY=@gpb.moe>
In-Reply-To: <70f63dd2e0ba7959a9e3bb7fa68ce14a@bastelstu.be>
References: <9zUVZKaEYixjCLLhviQPYFQtSAEhsRMWL6xbKeogzAGsH-STebN9JqJxITAPVfdKTNu7gEs_m77OkIcOzaiscoajx8Hp8VWRKkhTTCPkGko=@gpb.moe> <6E690732-8BED-4A01-8385-648E7CEDFD9F@sakiot.com> <70f63dd2e0ba7959a9e3bb7fa68ce14a@bastelstu.be>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Tuesday, 11 June 2024 at 20:47, Tim D=C3=BCsterhus <tim@bastelstu.be> wr=
ote:

> Hi
>=20
> Am 2024-06-08 02:29, schrieb Saki Takamachi:
>=20
> > Regarding 1, personally, I support Gina's opinion of only providing
> > the new rounding modes as an Enum.
> > This can be interpreted as changing the rounding mode to Enum, with
> > the existing constants being kept simply for backward compatibility.
>=20
>=20
> I've talked about this with Saki in private. We both agree that
> providing the 4 new rounding modes only by means of the proposed
> `RoundingMode` enum is the right choice. I have made the necessary
> adjustments to the RFC text. There is a new "Rounding Modes introduced
> in PHP 8.4" section that explains that the 4 constants will be removed
> as part of the `RoundingMode` enum RFC.
>=20
> Best regards
> Tim D=C3=BCsterhus

Thank you, I think other than possibly prefixing the NegativeInfinity
and PositiveInfinity cases with "Towards" I am happy with the content
of the RFC.


Best regards,

Gina P. Banyard