Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123586
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 11 Jun 2024 21:47:09 +0200
To: Saki Takamachi <saki@sakiot.com>
Cc: "Gina P. Banyard" <internals@gpb.moe>, Jorg Sowa <jorg.sowa@gmail.com>,
 php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and
 make it an Enum
In-Reply-To: <6E690732-8BED-4A01-8385-648E7CEDFD9F@sakiot.com>
References: <9zUVZKaEYixjCLLhviQPYFQtSAEhsRMWL6xbKeogzAGsH-STebN9JqJxITAPVfdKTNu7gEs_m77OkIcOzaiscoajx8Hp8VWRKkhTTCPkGko=@gpb.moe>
 <6E690732-8BED-4A01-8385-648E7CEDFD9F@sakiot.com>
Message-ID: <70f63dd2e0ba7959a9e3bb7fa68ce14a@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2024-06-08 02:29, schrieb Saki Takamachi:
> Regarding 1, personally, I support Gina's opinion of only providing
> the new rounding modes as an Enum.
> This can be interpreted as changing the rounding mode to Enum, with
> the existing constants being kept simply for backward compatibility.

I've talked about this with Saki in private. We both agree that 
providing the 4 new rounding modes only by means of the proposed 
`RoundingMode` enum is the right choice. I have made the necessary 
adjustments to the RFC text. There is a new "Rounding Modes introduced 
in PHP 8.4" section that explains that the 4 constants will be removed 
as part of the `RoundingMode` enum RFC.

Best regards
Tim Düsterhus