Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123578
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5
Precedence: bulk
MIME-Version: 1.0
Message-ID: <4d4df16b-af35-4245-85f4-016d66e8a4fa@app.fastmail.com>
In-Reply-To: <43606ecd-8838-476d-8fdf-acc6dbe26359@app.fastmail.com>
References: <0a6a61cd-f203-4dea-a7f8-97e6b885c52d@app.fastmail.com>
 <CAHSBg45uKCO9R9nrF6c7D1oZsEEwUxkkiRtMoA4fk0ECY--ekw@mail.gmail.com>
 <CP8P284MB21480B5455D962823CF634C593C62@CP8P284MB2148.BRAP284.PROD.OUTLOOK.COM>
 <43606ecd-8838-476d-8fdf-acc6dbe26359@app.fastmail.com>
Date: Tue, 11 Jun 2024 13:36:34 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Jun 11, 2024, at 6:47 AM, Rob Landers wrote:

> I=E2=80=99m also not a fan of the prefix style, but for different reas=
ons. My=20
> main reason is that it increases the minimum line-length, potentially=20
> forcing you to chop things down into awkward looking lines:
>
> public
> private(set)
> string $longvarname {
>  get;
>  set;
> }
>
> I find that extremely hard to scan, but maybe others do not. The more=20
> natural looking syntax is easier to scan and reason about (IMHO):
>
> public
> string $longvarname {
>  get;
>  private set;
> }
>
> If I=E2=80=99m having to read the code, I prefer to have everything ne=
ar where=20
> it is used so I don=E2=80=99t have to scroll up to the top and see its=20
> visibility. Granted, I haven=E2=80=99t used property hooks and I have =
no idea=20
> how IDEs will help here; maybe it is a non-issue =E2=80=94 but I guess=
 people=20
> still have to do code reviews which very rarely comes with IDE powers.
>
> =E2=80=94 Rob

I have never in my life seen someone split the visibility to a separate =
line from the type and variable name in PHP.  I don't know why anyone wo=
uld start now, especially not because of hooks or aviz.  I just checked =
and PER-CS very directly states "All keywords MUST be on a single line, =
and MUST be separated by a single space."  So splitting it like shown ab=
ove would be against standard coding conventions anyway.

This is really a strawman argument.

--Larry Garfield