Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123546
Content-Type: multipart/alternative;
 boundary="------------sOoA3j0dfGAIqC8lsRJES2yr"
Message-ID: <fa48b5a2-61d0-4019-a173-f353088edffb@processus.org>
Date: Fri, 7 Jun 2024 21:20:01 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC proposal : "new" keyword shorthand
To: internals@lists.php.net
References: <CAMuyDGP58tTGWiTN=e22x7A5DXxE7UTZ1X2No+zcf6sYUc4wmg@mail.gmail.com>
Content-Language: fr-FR, en-US
In-Reply-To: <CAMuyDGP58tTGWiTN=e22x7A5DXxE7UTZ1X2No+zcf6sYUc4wmg@mail.gmail.com>
From: pierre-php@processus.org (Pierre)

This is a multi-part message in MIME format.
--------------sOoA3j0dfGAIqC8lsRJES2yr
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Le 07/06/2024 à 18:03, Benoît Condaminet a écrit :
> Hello,
>
> Following the RFC process, I'm sending this to propose a PHP change. 
> More precisely a new zend language token.
>
> This is somehow linked to the recently accepted RFC called "new 
> MyClass()->method() without parentheses", the goal is to introduce a 
> shorthand for the "new" keyword.
>
> *Motivations :*
> The new keyword sometime has a bad DX, for example when chaining Class 
> instantiation like this :
> $foobar = new Foo( new Bar(), new Etc());
>
> We can quickly have very long class object construction in some case.
>
> In lot of Framework, to improve DX, static function construct are 
> often used to avoid the new keyword, some create additional object 
> builders, etc.
>
> As a first try, I start updated code to completely make the new 
> keyword optional, like in Dart language for example, but it require 
> very big change, with lot of impact (collision with function).
>
> So here is *my proposal : *
>
> Add a "new" shorthand, using the tilde character : "~"
> I made a POC, and it works well, declaring a new language 
> token T_SHORT_NEW that simply reuse ZEND_AST_NEW under the hood.
>
Hello,

I sincerely do not want to see a new operator for replacing the "new" 
operator, because then we would have two different syntaxes which would 
be semantically equivalent.

Creating a new object, in most API design, is not something you do very 
often, especially when working in a framework that does it for you 
(dependency injection, etc...).

And, moreover, when I'm searching who what where was created an specific 
class instance, I regex grep for "new\s+ClassName" and in most case, it 
works like a charm. If you add an operator for this, it simply will 
create a huge cognitive dissonance for simply no added value at all.

"New" is working fine, adding a shortcut for the sake of adding a 
shortcut to something you don't write that much doesn't worth it in my 
opinion: there are much more disadvantages that benefits.

Best regards,

Pierre

--------------sOoA3j0dfGAIqC8lsRJES2yr
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Le 07/06/2024 à 18:03, Benoît
      Condaminet a écrit :<br>
    </div>
    <blockquote type="cite"
cite="mid:CAMuyDGP58tTGWiTN=e22x7A5DXxE7UTZ1X2No+zcf6sYUc4wmg@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">Hello,
        <div><br>
        </div>
        <div>Following the RFC process, I'm sending this to propose a
          PHP change. More precisely a new zend language token. 
          <div><br>
          </div>
          <div>This is somehow linked to the recently accepted RFC
            called "new MyClass()-&gt;method() without parentheses", the
            goal is to introduce a shorthand for the "new" keyword. </div>
          <div><br>
          </div>
          <div><b>Motivations :</b></div>
          <div>The new keyword sometime has a bad DX, for example when
            chaining Class instantiation like this :</div>
          <div>$foobar = new Foo( new Bar(), new Etc());</div>
          <div><br>
          </div>
          <div>We can quickly have very long class object construction
            in some case. </div>
          <div><br>
          </div>
          <div>In lot of Framework, to improve DX, static function
            construct are often used to avoid the new keyword, some
            create additional object builders, etc.</div>
          <div><br>
          </div>
          <div>As a first try, I start updated code to completely make
            the new keyword optional, like in Dart language for example,
            but it require very big change, with lot of impact
            (collision with function). </div>
          <div><br>
          </div>
          <div>So here is <b>my proposal : </b></div>
          <div><br>
          </div>
          <div>Add a "new" shorthand, using the tilde character : "~"</div>
          <div>I made a POC, and it works well, declaring a new language
            token T_SHORT_NEW that simply reuse ZEND_AST_NEW under the
            hood. </div>
          <div><br>
          </div>
        </div>
      </div>
    </blockquote>
    <p>Hello,</p>
    <p>I sincerely do not want to see a new operator for replacing the
      "new" operator, because then we would have two different syntaxes
      which would be semantically equivalent.</p>
    <p>Creating a new object, in most API design, is not something you
      do very often, especially when working in a framework that does it
      for you (dependency injection, etc...).</p>
    <p>And, moreover, when I'm searching who what where was created an
      specific class instance, I regex grep for "new\s+ClassName" and in
      most case, it works like a charm. If you add an operator for this,
      it simply will create a huge cognitive dissonance for simply no
      added value at all.</p>
    <p>"New" is working fine, adding a shortcut for the sake of adding a
      shortcut to something you don't write that much doesn't worth it
      in my opinion: there are much more disadvantages that benefits.</p>
    <p>Best regards,</p>
    <p>Pierre<br>
    </p>
  </body>
</html>

--------------sOoA3j0dfGAIqC8lsRJES2yr--