Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123505
Precedence: bulk
MIME-Version: 1.0
References: <CAOWwgpmbq5VRrZQvUXDsKiNK4r6+bFA4VxnjQ_U=h8T9r0o3DA@mail.gmail.com>
In-Reply-To: <CAOWwgpmbq5VRrZQvUXDsKiNK4r6+bFA4VxnjQ_U=h8T9r0o3DA@mail.gmail.com>
Date: Tue, 4 Jun 2024 17:55:25 +0300
Message-ID: <CAPyeZ4NR7dVBuereYb0r4P3PRYF8y_pJcQLqEXazDQFKGqn9xQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Lazy Objects
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>, Arnaud Le Blanc <arnaud.lb@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000780c76061a11a45f"
From: udaltsov.valentin@gmail.com (Valentin Udaltsov)

--000000000000780c76061a11a45f
Content-Type: text/plain; charset="UTF-8"

On June, 4 at 15:32, Nicolas Grekas <nicolas.grekas+php@gmail.com> wrote:

> Dear all,
>
> Arnaud and I are pleased to share with you the RFC we've been shaping for
> over a year to add native support for lazy objects to PHP.
>
> Please find all the details here:
> https://wiki.php.net/rfc/lazy-objects
>
> We look forward to your thoughts and feedback.
>
> Cheers,
> Nicolas and Arnaud
>
Hi, Nicolas and Arnaud!

I like the idea, thank you for the RFC!

Here are some initial thoughts and questions:

1. It doesn't seem right that calling `ReflectionLazyObject::makeLazyGhost`
has an implicit side effect on `$instance` and returns reflection. It does
2 things and thus breaks the SRP. Having smth like `$lazyGhost = new
ReflectionClass(MyClass)->newLazyGhost($initializer)` and/or
`ReflectionLazyObject::makeLazy($object, $initializer): void` seems better.
2. If `ReflectionLazyObject extends ReflectionObject`, then how `new
ReflectionLazyObject($object)` will work for non-lazy objects? Will it
throw?
3. Is extending `ReflectionObject` really necessary? What about creating
`ReflectionLazyObject` as a standalone class without abusing inheritance?
Or simply adding methods to `ReflectionObject` / `ReflectionClass`?
4. The RFC says that Virtual state-proxies are necessary because of
circular references. It's difficult to accept this reasoning, because using
circular references is a bad practice and the given example is something I
try to avoid by all means in my code.

-- 
Best regards,
Valentin

--000000000000780c76061a11a45f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"></div><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On June, 4 at 15:32, Nicolas Grekas &lt;<a hr=
ef=3D"mailto:nicolas.grekas%2Bphp@gmail.com">nicolas.grekas+php@gmail.com</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><d=
iv dir=3D"ltr"><div dir=3D"ltr"><p>Dear all,</p><p>Arnaud and I are pleased=
 to share with
 you the RFC we&#39;ve been shaping for over a year to add native support=
=20
for lazy objects to PHP.</p><p>Please find all the details here:<br><a rel=
=3D"noreferrer" href=3D"https://wiki.php.net/rfc/lazy-objects" target=3D"_b=
lank">https://wiki.php.net/rfc/lazy-objects</a></p><p>We look forward to yo=
ur thoughts and feedback.</p><p>Cheers,<br>Nicolas and Arnaud</p></div></di=
v>
</blockquote></div>Hi, Nicolas and Arnaud!<br clear=3D"all"><div><br>I like=
 the idea,=C2=A0thank you for the=C2=A0RFC!<br><br></div><div>Here are some=
 initial thoughts and questions:<br><br>1. It doesn&#39;t seem right that c=
alling `ReflectionLazyObject::makeLazyGhost` has an implicit side effect on=
 `$instance` and returns reflection. It does 2 things and thus breaks the S=
RP. Having smth like `$lazyGhost =3D new ReflectionClass(MyClass)-&gt;newLa=
zyGhost($initializer)` and/or `ReflectionLazyObject::makeLazy($object, $ini=
tializer): void` seems better.<br></div><div>2. If `ReflectionLazyObject ex=
tends ReflectionObject`, then how `new ReflectionLazyObject($object)` will =
work for non-lazy objects? Will it throw?<br>3. Is extending=C2=A0`Reflecti=
onObject` really necessary? What about creating `ReflectionLazyObject` as a=
 standalone class without abusing inheritance? Or simply adding methods to =
`ReflectionObject` / `ReflectionClass`?</div><div>4. The RFC says that=C2=
=A0Virtual state-proxies are necessary because of circular references. It&#=
39;s=C2=A0difficult to accept=C2=A0this reasoning, because using circular=
=C2=A0references is a bad=C2=A0practice and the given example is something=
=C2=A0I try to avoid by all means in my code.<br><br></div><span class=3D"g=
mail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signat=
ure"><div dir=3D"ltr">Best regards,<br>Valentin</div></div></div>

--000000000000780c76061a11a45f--