Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123498
Message-ID: <71e8bd9b-3dcb-45e3-966b-9eefe567efa5@bastelstu.be>
Date: Mon, 3 Jun 2024 20:11:20 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and
 make it an Enum
To: Derick Rethans <derick@php.net>, "Gina P. Banyard" <internals@gpb.moe>
Cc: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com>
 <CAPTD5yF+C+xK1LSoAOZS_y1dP-LThCAsAFg4x=bHcqjk0NiceQ@mail.gmail.com>
 <73ae49a3-473a-46f2-add6-164b0a01e357@app.fastmail.com>
 <5iUDJtfp_0xWjhfj9MpeJhmZz5awy0RyBF3udkM1TjF5HRfbMKoZrqVNJJWM_g07J1oLDZxsJh_6WbGEaqdNj6ZiE96SjLhfv_r62YTMiRo=@gpb.moe>
 <93f6b448-7c7a-5c64-3d29-f96452c9d686@php.net>
Content-Language: en-US
In-Reply-To: <93f6b448-7c7a-5c64-3d29-f96452c9d686@php.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/3/24 18:21, Derick Rethans wrote:
> But they're well established in existing PHP features.

That does not mean that we shouldn't attempt to do better for newly 
introduced APIs. Over time there will be more developers that will newly 
learn PHP than there are developers that already know PHP’s standard 
library in detail.

Of course that does not mean that we should break consistency with 
existing functionality without good justification, but in the case of 
the `RoundingMode` enum, the enum is self-contained and with the 
addition of the new rounding modes in PHP 8.4 [1], the existing `ceil()` 
and `floor()` functions are redundant with the capabilities of 
`round()`. Anyone who newly learns PHP would get all the functionality 
by just using `round()` together with one of the self-explanatory 
rounding modes provided by the proposed `RoundingMode` enum.

Best regards
Tim Düsterhus

[1] https://wiki.php.net/rfc/new_rounding_modes_to_round_function