Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123496
Message-ID: <50e27d08-48d0-42e3-9abc-f5830264d75f@bastelstu.be>
Date: Mon, 3 Jun 2024 19:57:23 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and
 make it an Enum
To: Jordan LeDoux <jordan.ledoux@gmail.com>, Jorg Sowa <jorg.sowa@gmail.com>
Cc: "Gina P. Banyard" <internals@gpb.moe>,
 Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com>
 <CAPTD5yF+C+xK1LSoAOZS_y1dP-LThCAsAFg4x=bHcqjk0NiceQ@mail.gmail.com>
 <73ae49a3-473a-46f2-add6-164b0a01e357@app.fastmail.com>
 <5iUDJtfp_0xWjhfj9MpeJhmZz5awy0RyBF3udkM1TjF5HRfbMKoZrqVNJJWM_g07J1oLDZxsJh_6WbGEaqdNj6ZiE96SjLhfv_r62YTMiRo=@gpb.moe>
 <CAPTD5yGUAtupy96kpmXvsbneJ=iBmH_WkP3ZhEc6tbnXb+debg@mail.gmail.com>
 <CAMrTa2GNUrTp7vN5bh8gEoe+z9ZK+q4gmW74vrO34tmeekbW0A@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAMrTa2GNUrTp7vN5bh8gEoe+z9ZK+q4gmW74vrO34tmeekbW0A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/3/24 19:02, Jordan LeDoux wrote:
> If the behavior of that mode is to ALWAYS round regardless of the value of
> the remainder, then it should remain ceil IMO. It's a pretty well
> understood behavior in many programming languages. However,
> "HALF_TOWARDS_POSITIVE_INFINITY" is a different behavior, and should not be
> called ceil.

There's already `HalfAwayFromZero` + `AwayFromZero` as companion modes. 
It would make sense to me to also make it `PositiveInfinity` + 
`HalfPositiveInfinity` [1] instead of `Ceil` + `HalfPositiveInfinity`, 
which are appear to be unrelated based on their naming.

That would make it clear that those two are closely related and also 
that all the modes starting with 'Half' would be the ones that are only 
relevant if the last digit is 5, whereas the others act unconditionally.

Best regards
Tim Düsterhus

[1] Possibly with an 'Towards' inserted before the Negative/Positive.