Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123492
Date: Mon, 3 Jun 2024 17:21:22 +0100 (BST)
To: "Gina P. Banyard" <internals@gpb.moe>
cc: Larry Garfield <larry@garfieldtech.com>, 
    php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode
 and make it an Enum
In-Reply-To: <5iUDJtfp_0xWjhfj9MpeJhmZz5awy0RyBF3udkM1TjF5HRfbMKoZrqVNJJWM_g07J1oLDZxsJh_6WbGEaqdNj6ZiE96SjLhfv_r62YTMiRo=@gpb.moe>
Message-ID: <93f6b448-7c7a-5c64-3d29-f96452c9d686@php.net>
References: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com> <CAPTD5yF+C+xK1LSoAOZS_y1dP-LThCAsAFg4x=bHcqjk0NiceQ@mail.gmail.com> <73ae49a3-473a-46f2-add6-164b0a01e357@app.fastmail.com>
 <5iUDJtfp_0xWjhfj9MpeJhmZz5awy0RyBF3udkM1TjF5HRfbMKoZrqVNJJWM_g07J1oLDZxsJh_6WbGEaqdNj6ZiE96SjLhfv_r62YTMiRo=@gpb.moe>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
From: derick@php.net (Derick Rethans)

On Sat, 1 Jun 2024, Gina P. Banyard wrote:

> On Friday, 31 May 2024 at 18:15, Larry Garfield <larry@garfieldtech.com> wrote:
> 
> > On Fri, May 31, 2024, at 4:41 PM, Jorg Sowa wrote:
> > 
> > > Hey Saki, I like this change. When I was implementing additional 
> > > rounding modes for the next PHP version I was initially struggling 
> > > with the naming and this change will be helpful.
> > > 
> > > I have only one concern about the names `NegativeInfinity` and 
> > > `PositiveInfinity`. They may be too formal from the user's 
> > > perspective. As we already have functions `ceil` and `floor` it's 
> > > more intuitive for developers to understand the logic of ceiling 
> > > and floor rounding.
> > > 
> > > But if voters will prefer those terms then it makes sense to 
> > > change the constants implemented in PHP 8.4 (and thus not released 
> > > yet) from `PHP_ROUND_(CEILING|FLOOR)` to 
> > > `PHP_ROUND_(POSITIVE_INFINITY|NEGATIVE_INFINITY)` for the sake of 
> > > consistency.
> > 
> > I was confused by those as well. It's not obvious to me what those 
> > even do. Do they mean "away from 0"? If not, then I have no clue 
> > what they are. :-)
> 
> Considering that there are already "Away from 0" and "Towards 0" enum 
> cases, the Towards Positive Infinity/Towards Negative Infinity cases 
> "obviously" don't mean this.
> 
> Towards positive infinity means that for positive numbers you round to 
> the integer part plus 1, and for negative numbers you "just" take the 
> negative integer part. Similarly, for rounding towards negative 
> infinity positive numbers round to "just" the integer part of it, and 
> negative numbers round to the negative integer part minus 1.
> 
> It should also be noted that ceil/floor is very English specific 
> terminology that may not be immediately obvious to non-English 
> speakers, thus my preference for using some variation of towards 
> positive/negative infinity.

But they're well established in existing PHP features.

cheers,
Derick

-- 
https://derickrethans.nl | https://xdebug.org | https://dram.io

Author of Xdebug. Like it? Consider supporting me: https://xdebug.org/support

mastodon: @derickr@phpc.social @xdebug@phpc.social