Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123485
Date: Sat, 01 Jun 2024 05:25:35 +0000
To: Saki Takamachi <saki@sakiot.com>
Cc: php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and make it an Enum
Message-ID: <duscobxrPBBlZDJkfGysjlqjRCUegugbMWkPCiCd8czpPiKYfqK4dHAwwQwlp1D10xcAVdrBFIiL-fut-TVcHDJB1lMSPCHB-rVHCeNZl1s=@gpb.moe>
In-Reply-To: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com>
References: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")




On Friday, 31 May 2024 at 15:49, Saki Takamachi <saki@sakiot.com> wrote:

> Hi, internals!
>=20
> I would like to start an RFC discussion regarding rounding modes.
> https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_=
enum
>=20
> As mentioned previously by Gina on the mailing list [1], there are some i=
ssues with PHP's current rounding mode.
> [1] - https://externals.io/message/123126
>=20
> =E2=80=A2 First, the value is just an int, so we need to verify that the =
value passed is a valid rounding mode.
> =E2=80=A2 The second problem is that the behavior of the =E2=80=9Cup=
=E2=80=9D and =E2=80=9Cdown=E2=80=9D modes does not match the mathematical =
definition. Especially for non-native speakers, the different rounding mode=
s might also be more easily confused, compared to a naming that uses less a=
bstract terms.
>=20
> To resolve these issues, change the naming to something appropriate and u=
se Enums instead of int constants.
>=20
> Please see the RFC for details.
>=20
> Regards,
>=20
> Saki

IMHO, part of the RFC should be to amend the "Add 4 new rounding modes to r=
ound() function" RFC [1] by *removing* the newly introduced constant and in=
stead exposing the functionality *only* via the new Enum.
Especially as those constant have not yet been in a stable release of PHP.

Other than that, and seeing the confusing of some other people, maybe using=
 the names "TowardsPositiveInfinity" and "TowardsNegativeInfinity" is bette=
r.


Best regards,

Gina P. Banyard