Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123478
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2
Precedence: bulk
MIME-Version: 1.0
Message-ID: <73ae49a3-473a-46f2-add6-164b0a01e357@app.fastmail.com>
In-Reply-To: 
 <CAPTD5yF+C+xK1LSoAOZS_y1dP-LThCAsAFg4x=bHcqjk0NiceQ@mail.gmail.com>
References: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com>
 <CAPTD5yF+C+xK1LSoAOZS_y1dP-LThCAsAFg4x=bHcqjk0NiceQ@mail.gmail.com>
Date: Fri, 31 May 2024 17:15:24 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and make it
 an Enum
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Fri, May 31, 2024, at 4:41 PM, Jorg Sowa wrote:
> Hey Saki,
> I like this change. When I was implementing additional rounding modes 
> for the next PHP version I was initially struggling with the naming and 
> this change will be helpful.
>
> I have only one concern about the names `NegativeInfinity` and 
> `PositiveInfinity`. They may be too formal from the user's perspective. 
> As we already have functions `ceil` and `floor` it's more intuitive for 
> developers to understand the logic of ceiling and floor rounding.
>
> But if voters will prefer those terms then it makes sense to change the 
> constants implemented in PHP 8.4 (and thus not released yet) from 
> `PHP_ROUND_(CEILING|FLOOR)` to 
> `PHP_ROUND_(POSITIVE_INFINITY|NEGATIVE_INFINITY)` for the sake of 
> consistency.
>
> Kind regards,
> Jorg

I was confused by those as well.  It's not obvious to me what those even do.  Do they mean "away from 0"?  If not, then I have no clue what they are. :-)

--Larry Garfield