Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123476
Precedence: bulk
MIME-Version: 1.0
References: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com>
In-Reply-To: <81CBE5A8-9FAF-40DA-8EAB-9F19C2278E75@sakiot.com>
Date: Fri, 31 May 2024 18:41:48 +0200
Message-ID: <CAPTD5yF+C+xK1LSoAOZS_y1dP-LThCAsAFg4x=bHcqjk0NiceQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [discussion] Correctly name the rounding mode and
 make it an Enum
To: Saki Takamachi <saki@sakiot.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009282ed0619c2a90b"
From: jorg.sowa@gmail.com (Jorg Sowa)

--0000000000009282ed0619c2a90b
Content-Type: text/plain; charset="UTF-8"

Hey Saki,
I like this change. When I was implementing additional rounding modes for
the next PHP version I was initially struggling with the naming and this
change will be helpful.

I have only one concern about the names `NegativeInfinity` and
`PositiveInfinity`. They may be too formal from the user's perspective. As
we already have functions `ceil` and `floor` it's more intuitive for
developers to understand the logic of ceiling and floor rounding.

But if voters will prefer those terms then it makes sense to change the
constants implemented in PHP 8.4 (and thus not released yet) from
`PHP_ROUND_(CEILING|FLOOR)` to
`PHP_ROUND_(POSITIVE_INFINITY|NEGATIVE_INFINITY)` for the sake of
consistency.

Kind regards,
Jorg

--0000000000009282ed0619c2a90b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div><div><div><div>Hey Saki,<br></div>I like this ch=
ange. When I was implementing additional rounding modes for the next PHP ve=
rsion I was initially struggling with the naming and this change will be he=
lpful.<br><br></div>I have only one concern about the names `NegativeInfini=
ty<span class=3D"gmail-sy0"></span>` and `PositiveInfinity`. They may be to=
o formal from the user&#39;s perspective. As we already have functions `cei=
l` and `floor` it&#39;s more intuitive for developers to understand the log=
ic of ceiling and floor rounding.<br><br></div>But if voters will prefer th=
ose terms then it makes sense to change the constants implemented in PHP 8.=
4 (and thus not released yet) from `PHP_ROUND_(CEILING|FLOOR)` to `PHP_ROUN=
D_(POSITIVE_INFINITY|NEGATIVE_INFINITY)` for the sake of consistency.<br><b=
r></div>Kind regards,<br></div>Jorg<br></div>

--0000000000009282ed0619c2a90b--