Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123463
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2
Precedence: bulk
MIME-Version: 1.0
Message-ID: <1b0e9a5d-14f9-4df4-8a75-286bfb70ee3e@app.fastmail.com>
In-Reply-To: <d7d4911c-3488-4109-a416-cbaa74648688@bastelstu.be>
References: <0a6a61cd-f203-4dea-a7f8-97e6b885c52d@app.fastmail.com>
 <d7d4911c-3488-4109-a416-cbaa74648688@bastelstu.be>
Date: Wed, 29 May 2024 21:12:25 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, May 29, 2024, at 7:51 PM, Tim D=C3=BCsterhus wrote:
> Hi
>
> On 5/29/24 21:15, Larry Garfield wrote:
>> * We've brought back the abbreviated form, as public-read, something =
else set is the most common use case.
>
> The most common use case is that 'get' and 'set' are symmetric.=20

OK, fair, I meant in the most common case where you're using aviz at all=
, get is probably public.

That said, with both hooks and aviz, I can see data objects, for instanc=
e, becoming commonly public-get, private-set.  It's already common to ha=
ve them be public readonly, so this is just an extension of that.

> Any=20
> divergence from that should stand out and I think that the hamming=20
> distance between
>
>      protected string $foo;
>
> and
>
>      protected(set) string $foo;
>
> is too small.

I can only respectfully disagree here.  I think it's reasonably self-evi=
dent, made moreso by the (), which as Andreas noted looks weird when you=
're not used to it (but we should get used to fairly quickly).  And the =
benefit of not having to type "public" on every property outweighs any i=
nitial confusion, much the same as readonly classes just reduces boilerp=
late.

> One note regarding the text. You already confirmed to me in private th=
at:
>
>      class Foo {
>          private $dontTouchMe;
>      }
>
>      $backdoor =3D function ($key, $value) { $this->{$key} =3D $value;=
 };
>
>      $f =3D new Foo();
>      $backdoor->call($f, 'dontTouchMe', 'butIDid');
>      var_dump($f);
>
> would work as expected with aviz. It would make sense to explicitly=20
> spell that out, just like it's explicitly spelled out that=20
> `ReflectionProperty::setValue()` works.

Added a note to that effect in the Reflection section as well.  Thanks.

--Larry Garfield