Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123457
Message-ID: <d7d4911c-3488-4109-a416-cbaa74648688@bastelstu.be>
Date: Wed, 29 May 2024 21:51:03 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2
To: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <0a6a61cd-f203-4dea-a7f8-97e6b885c52d@app.fastmail.com>
Content-Language: en-US
In-Reply-To: <0a6a61cd-f203-4dea-a7f8-97e6b885c52d@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 5/29/24 21:15, Larry Garfield wrote:
> * We've brought back the abbreviated form, as public-read, something else set is the most common use case.

The most common use case is that 'get' and 'set' are symmetric. Any 
divergence from that should stand out and I think that the hamming 
distance between

     protected string $foo;

and

     protected(set) string $foo;

is too small.

Other than that the proposal looks good to me. Ship it.

------

One note regarding the text. You already confirmed to me in private that:

     class Foo {
         private $dontTouchMe;
     }

     $backdoor = function ($key, $value) { $this->{$key} = $value; };

     $f = new Foo();
     $backdoor->call($f, 'dontTouchMe', 'butIDid');
     var_dump($f);

would work as expected with aviz. It would make sense to explicitly 
spell that out, just like it's explicitly spelled out that 
`ReflectionProperty::setValue()` works.

Best regards
Tim Düsterhus