Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123447
Precedence: bulk
MIME-Version: 1.0
References: <GUMp_LJKefk4aLz9P9MA-zonKuik6uUNWZTtOAx-IeIhjPFsgfT3HHECPpyGF_ujq-LxI6tzBxMYgL5CMVGRkyzxSugweKix_YUGo2rXnb4=@gpb.moe>
 <b2IQjZQlOsMoMuk9Jw5edeVfHqqbcWCQc6DQF5jKrRkGryVyvu6rC9sbSW2D-HK9jH2QUmkoIy--aQROFsx-3QPr8CjIfltTnhbZYGxsixI=@gpb.moe>
 <CAPyj-LBpmYv30JFW3x-ZL=28vivrh7d04L97rbXeYxDJirwKCg@mail.gmail.com> <QAC7c6IKEQT1Tc1vJj9mFObkMy-4EYbXpb08ziJ4mSw3iOHKEdffmQ8Ae3W0XZpNLwsKoW6-IRRkLNiRHIRnUlGBp9jCE4JKgrpa05xjoj8=@gpb.moe>
In-Reply-To: <QAC7c6IKEQT1Tc1vJj9mFObkMy-4EYbXpb08ziJ4mSw3iOHKEdffmQ8Ae3W0XZpNLwsKoW6-IRRkLNiRHIRnUlGBp9jCE4JKgrpa05xjoj8=@gpb.moe>
Date: Tue, 28 May 2024 15:10:39 +0200
Message-ID: <CAPyj-LBg6d1TJ+_udVyo9RGxUK_MKefWgECh_w7ZX5O_fV1ogw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Transform exit() from a language construct into a
 standard function
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

On Tue, May 28, 2024 at 2:10=E2=80=AFPM Gina P. Banyard <internals@gpb.moe>=
 wrote:
>
> On Monday, 27 May 2024 at 02:31, Ilija Tovilo <tovilo.ilija@gmail.com> wr=
ote:
>
> > > On Wednesday, 8 May 2024 at 14:40, Gina P. Banyard internals@gpb.moe =
wrote:
> > >
> > > > I would like to formally propose my idea for exit() as a function b=
rought up to the list on 2024-02-24 [1] with the following RFC:
> > > > https://wiki.php.net/rfc/exit-as-function
> >
> >
> > As mentioned early on in private, I don't see a convincing reason to
> > remove tokenizer/parser support for exit/die. I'd rather see this
> > handled in the parser directly, by converting the standalone keywords
> > to function calls. This avoids any backwards incompatibility, and
> > avoids special handling in zend_compile_const.
>
> I must be honest, I don't really understand how parsers work, so I went w=
ith what I could understand and implement.
> But I'm struggling to see a reason for keeping the token in the first pla=
ce, and what issues hooking into zend_compile_const() has.

Mostly because I think handling exit and die as constants is
misleading. exit; isn't a constant any more than yield; is. Instead,
you could turn exit; into the same AST as exit(); (i.e. a function
call), which will make the compiler handle it automatically. If you
wish, I can have a quick look.

> > Another thing that's probably not too important: The PR likely breaks
> > dead code elimination for exit() and die(). This could be re-added by
> > checking for the never return type instead.
>
> Checking for a never return type seems more robust if it wasn't already s=
upported by DCE.
> I will see if I can do this.

That would be great! I agree that this can be done in retrospect.

Ilija