Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123446
Date: Tue, 28 May 2024 12:10:32 +0000
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Transform exit() from a language construct into a standard function
Message-ID: <QAC7c6IKEQT1Tc1vJj9mFObkMy-4EYbXpb08ziJ4mSw3iOHKEdffmQ8Ae3W0XZpNLwsKoW6-IRRkLNiRHIRnUlGBp9jCE4JKgrpa05xjoj8=@gpb.moe>
In-Reply-To: <CAPyj-LBpmYv30JFW3x-ZL=28vivrh7d04L97rbXeYxDJirwKCg@mail.gmail.com>
References: <GUMp_LJKefk4aLz9P9MA-zonKuik6uUNWZTtOAx-IeIhjPFsgfT3HHECPpyGF_ujq-LxI6tzBxMYgL5CMVGRkyzxSugweKix_YUGo2rXnb4=@gpb.moe> <b2IQjZQlOsMoMuk9Jw5edeVfHqqbcWCQc6DQF5jKrRkGryVyvu6rC9sbSW2D-HK9jH2QUmkoIy--aQROFsx-3QPr8CjIfltTnhbZYGxsixI=@gpb.moe> <CAPyj-LBpmYv30JFW3x-ZL=28vivrh7d04L97rbXeYxDJirwKCg@mail.gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Monday, 27 May 2024 at 02:31, Ilija Tovilo <tovilo.ilija@gmail.com> wrot=
e:

> Hi Gina
>=20
> On Sun, May 26, 2024 at 11:47=E2=80=AFPM Gina P. Banyard internals@gpb.mo=
e wrote:
>=20
> > On Wednesday, 8 May 2024 at 14:40, Gina P. Banyard internals@gpb.moe wr=
ote:
> >=20
> > > I would like to formally propose my idea for exit() as a function bro=
ught up to the list on 2024-02-24 [1] with the following RFC:
> > > https://wiki.php.net/rfc/exit-as-function
> >=20
> > As there haven't been any comments for nearly two weeks, I'm planning o=
n opening the vote for the RFC on Tuesday.
>=20
>=20
> As mentioned early on in private, I don't see a convincing reason to
> remove tokenizer/parser support for exit/die. I'd rather see this
> handled in the parser directly, by converting the standalone keywords
> to function calls. This avoids any backwards incompatibility, and
> avoids special handling in zend_compile_const.

I must be honest, I don't really understand how parsers work, so I went wit=
h what I could understand and implement.
But I'm struggling to see a reason for keeping the token in the first place=
, and what issues hooking into zend_compile_const() has.

>=20
> Another thing that's probably not too important: The PR likely breaks
> dead code elimination for exit() and die(). This could be re-added by
> checking for the never return type instead.

Checking for a never return type seems more robust if it wasn't already sup=
ported by DCE.
I will see if I can do this.

> You'd also need to
> special-case the lookup of exit/die in namespaced code, where it will
> always refer to the global function (as they cannot be declared in
> userland).

This is a pre-existing issue with assert() too then, I am happy to fix this=
 at the same time if the RFC passes.


Best regards,

Gina P. Banyard