Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:12344
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Wed, 25 Aug 2004 07:08:39 +0100
To: internals@lists.php.net
Message-ID: <20040825060839.GA18528@redhat.com>
Mail-Followup-To: internals@lists.php.net
References: <20040824145341.GG29369@redhat.com> <200408242053.17252.ilia@prohost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <200408242053.17252.ilia@prohost.org>
User-Agent: Mutt/1.4.1i
Subject: Re: [PHP-DEV] [PATCH] zend_compile.c warning fix
From: jorton@redhat.com (Joe Orton)

On Tue, Aug 24, 2004 at 08:53:15PM -0400, Ilia Alshanetsky wrote:
> What compiler flags are you using that you see this warning message? I do not 
> see on the local build here.

gcc -Wall warns, any LP64 platform.

Zend/zend_compile.c: In function `build_runtime_defined_function_key':
Zend/zend_compile.c:71: warning: cast from pointer to integer of different size

> On August 24, 2004 10:53 am, Joe Orton wrote:
> > If casting pointers to integers at least cast to a long, to avoid
> > compiler warnings:
> >
> > --- Zend/zend_compile.c	23 Aug 2004 20:58:48 -0000	1.581
> > +++ Zend/zend_compile.c	24 Aug 2004 14:50:31 -0000
> > @@ -68,7 +68,7 @@
> >  	uint char_pos_len;
> >  	char *filename;
> >
> > -	char_pos_len = zend_sprintf(char_pos_buf, "%x", (unsigned int)
> > LANG_SCNG(_yy_last_accepting_cpos)); +	char_pos_len =
> > zend_sprintf(char_pos_buf, "%lx", (unsigned long)
> > LANG_SCNG(_yy_last_accepting_cpos)); if (CG(active_op_array)->filename) {
> >  		filename = CG(active_op_array)->filename;
> >  	} else {