Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123434
Precedence: bulk
MIME-Version: 1.0
References: <CAPyeZ4M02SKfsacTNC7SPAptRfLnPyYbOJMuAM9og-azbA0CxQ@mail.gmail.com>
In-Reply-To: <CAPyeZ4M02SKfsacTNC7SPAptRfLnPyYbOJMuAM9og-azbA0CxQ@mail.gmail.com>
Date: Mon, 27 May 2024 14:21:23 +0300
Message-ID: <CAAwdEzAD1JpGOy46RZaS6mQmaZMOFWDcEeHUtqVJY9+cs1y+cA@mail.gmail.com>
Subject: Re: [PHP-DEV] Extract ArrayAccessRead from ArrayAccess
To: Valentin Udaltsov <udaltsov.valentin@gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000cd4e6e06196db8ec"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000cd4e6e06196db8ec
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 27, 2024 at 7:16=E2=80=AFAM Valentin Udaltsov <
udaltsov.valentin@gmail.com> wrote:

> Hello, internals!
>
> Here's the idea: let's extract `ArrayAccess::offsetExists` and
> `ArrayAccess::offsetGet` methods into a separate `ArrayAccessRead`
> interface (name can be different) and allow read operations `$exists =3D
> isset($object['key'])` and `$value =3D $object['key']` for objects of cla=
sses
> that implement this interface. `ArrayAccess` will then extend
> `ArrayAccessRead` and add the remaining 2 methods. Looks like this change
> should not break backward compatibility.
>
>
Please check this: https://externals.io/message/122609#122609 where Gina
analyzed and proposed a solution for this.
It looks like the DimensionReadable is exactly the same thing. Maybe also
DimensionFetchable if you consider returning by reference.

Maybe the improvement can be done in smaller incremental steps, but I think
it's better to agree on a complete solution for splitting ArrayAccess.

Regards,
Alex

--000000000000cd4e6e06196db8ec
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Mon, May 27, 2024 at 7:16=E2=80=AFAM V=
alentin Udaltsov &lt;<a href=3D"mailto:udaltsov.valentin@gmail.com" target=
=3D"_blank">udaltsov.valentin@gmail.com</a>&gt; wrote:<br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px so=
lid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hello, internals!<b=
r><br><div>Here&#39;s the idea: let&#39;s extract `ArrayAccess::offsetExist=
s` and `ArrayAccess::offsetGet` methods into a separate `ArrayAccessRead` i=
nterface (name can be different) and allow read operations `$exists =3D iss=
et($object[&#39;key&#39;])` and `$value =3D $object[&#39;key&#39;]` for obj=
ects of classes that implement this interface. `ArrayAccess` will then exte=
nd `ArrayAccessRead` and add the remaining 2 methods. Looks like this chang=
e should not break backward compatibility.<br></div><div><br></div></div></=
blockquote><div><br></div><div>Please check this:=C2=A0<a href=3D"https://e=
xternals.io/message/122609#122609" target=3D"_blank">https://externals.io/m=
essage/122609#122609</a>=C2=A0where Gina analyzed and proposed a solution f=
or this.</div><div>It looks like the=C2=A0<span style=3D"background-color:r=
gba(175,184,193,0.2);color:rgb(31,35,40);font-family:ui-monospace,SFMono-Re=
gular,&quot;SF Mono&quot;,Menlo,Consolas,&quot;Liberation Mono&quot;,monosp=
ace;font-size:13.6px">DimensionReadable</span>=C2=A0is exactly the same thi=
ng. Maybe also=C2=A0<span style=3D"background-color:rgba(175,184,193,0.2);c=
olor:rgb(31,35,40);font-family:ui-monospace,SFMono-Regular,&quot;SF Mono&qu=
ot;,Menlo,Consolas,&quot;Liberation Mono&quot;,monospace;font-size:13.6px">=
DimensionFetchable</span>=C2=A0if you consider returning by reference.<br><=
/div><div><br></div><div>Maybe the improvement can be done in smaller incre=
mental steps, but I think it&#39;s better to agree on a complete solution f=
or splitting=C2=A0ArrayAccess.</div><div><br></div><div>Regards,</div><div>=
Alex</div></div></div>

--000000000000cd4e6e06196db8ec--