Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123428
Message-ID: <b26e5cbe-8b50-4850-a98e-3aa9ff1f8d2c@bastelstu.be>
Date: Sat, 25 May 2024 10:57:34 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
To: Valentin Udaltsov <udaltsov.valentin@gmail.com>,
 =?UTF-8?Q?Joshua_R=C3=BCsweg?= <josh@wcflabs.de>
Cc: PHP internals <internals@lists.php.net>
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <CAPyeZ4MzW-oRQr65ifGDkCDs_XmaSBF4-+h0vhA0hB13iZFfEw@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAPyeZ4MzW-oRQr65ifGDkCDs_XmaSBF4-+h0vhA0hB13iZFfEw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 5/25/24 01:19, Valentin Udaltsov wrote:
> Have you considered renaming `$callback` parameter to `$predicate`? I
> always considered "callback" to be a very generic word. Predicate, on the
> contrary, implies accepting a value and returning a bool.
> 

For an entirely new API I would agree. But for the array_* functions we 
already have $callback for array_filter (and also array_map and 
array_reduce, but those are not predicate callbacks).

Also given the vote started with the $callback name and the fact that 
parameter names are part of the API (due to named parameters), it's 
probably to late to change it.

Best regards
Tim Düsterhus