Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123427
Precedence: bulk
MIME-Version: 1.0
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
In-Reply-To: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
Date: Sat, 25 May 2024 02:19:08 +0300
Message-ID: <CAPyeZ4MzW-oRQr65ifGDkCDs_XmaSBF4-+h0vhA0hB13iZFfEw@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
To: =?UTF-8?Q?Joshua_R=C3=BCsweg?= <josh@wcflabs.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b0537706193b6562"
From: udaltsov.valentin@gmail.com (Valentin Udaltsov)

--000000000000b0537706193b6562
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 7, 2024, at 10:20 AM, Joshua R=C3=BCsweg wrote:

> Hi
> I have created an RFC to add the function array_find which returns the
> first element for which a predicate callback returns true. This is a
> function which I missed often. Furthermore this type of function is
> implemented with other programming languages like C++, JavaScript and Rus=
t,
> too.
> You can find the RFC at:
> https://wiki.php.net/rfc/array_find
> Proof of concept implementation is in:
>
> https://github.com/joshuaruesweg/php-src/commit/9f3fc252b92f534d498e5f1e6=
a463e15f45da208
> I'm looking forward to your feedback.
> Cheers
> Joshua R=C3=BCsweg
>
>
Hi, Joshua!

Have you considered renaming `$callback` parameter to `$predicate`? I
always considered "callback" to be a very generic word. Predicate, on the
contrary, implies accepting a value and returning a bool.

--=20
Valentin Udaltsov

--000000000000b0537706193b6562
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"></div><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Sun, Apr 7, 2024, at 10:20 AM, Joshua R=C3=
=BCsweg wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0=
px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><=
u></u>

 =20

   =20
 =20
  <div>
    <div style=3D"color:rgb(212,212,212);background-color:rgb(33,33,34);fon=
t-family:Menlo,Monaco,&quot;Courier New&quot;,monospace;font-weight:normal;=
font-size:14px;line-height:21px;white-space:pre-wrap"><div><span style=3D"c=
olor:rgb(212,212,212)">Hi </span></div>
<div><span style=3D"color:rgb(212,212,212)">I have created an RFC to add th=
e function array_find which returns the first element for which a predicate=
 callback returns true. This is a function which I missed often. Furthermor=
e this type of function is implemented with other programming languages lik=
e C++, JavaScript and Rust, too. </span></div>
<div><span style=3D"color:rgb(212,212,212)">You can find the RFC at: </span=
></div>
<div><span style=3D"color:rgb(212,212,212)"><a href=3D"https://wiki.php.net=
/rfc/array_find" target=3D"_blank">https://wiki.php.net/rfc/array_find</a><=
/span></div>
<div><span style=3D"color:rgb(212,212,212)">Proof of concept implementation=
 is in:</span></div>
<div><span style=3D"color:rgb(212,212,212)"><a href=3D"https://github.com/j=
oshuaruesweg/php-src/commit/9f3fc252b92f534d498e5f1e6a463e15f45da208" targe=
t=3D"_blank">https://github.com/joshuaruesweg/php-src/commit/9f3fc252b92f53=
4d498e5f1e6a463e15f45da208</a></span></div>
<div><span style=3D"color:rgb(212,212,212)">I&#39;m looking forward to your=
 feedback.</span></div>
<div><span style=3D"color:rgb(212,212,212)">Cheers</span></div>
<div><span style=3D"color:rgb(212,212,212)">Joshua R=C3=BCsweg </span></div=
></div>
    <p></p>
  </div>

</blockquote></div><br>Hi, Joshua!<br><br>Have you considered renaming `$ca=
llback` parameter to `$predicate`? I always considered &quot;callback&quot;=
 to be a very generic word. Predicate, on the contrary, implies accepting a=
 value and returning a bool.<br clear=3D"all"><div><br></div><span class=3D=
"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_sign=
ature"><div dir=3D"ltr">Valentin Udaltsov<br></div></div></div>

--000000000000b0537706193b6562--