Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123404
Message-ID: <31b39501-e42f-4563-a4c6-1efafdf34512@gmail.com>
Date: Wed, 22 May 2024 19:47:36 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to
 XML{Reader,Writer}
To: PHP internals <internals@lists.php.net>
References: <CAJp_myWSagrqv3uH6CNxx0qskEsq0Ds-7Srf6DwSvn+4MT8B+w@mail.gmail.com>
 <721C2420-62AB-4586-AFAA-2E831C678EB5@gmail.com>
Content-Language: en-US
In-Reply-To: <721C2420-62AB-4586-AFAA-2E831C678EB5@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: dossche.niels@gmail.com (Niels Dossche)

On 21/05/2024 21:58, Claude Pache wrote:
> 
> 
>> Le 21 mai 2024 à 21:00, Matthew Weier O'Phinney <mweierophinney@gmail.com> a écrit :
>>
>>     (But again, I prefer that all those methods work on instances, as it was the case before PHP 8. They shouldn’t have been switched to static-but-broken-for-subclasses without discussion.)
>>
>>
>> Fixing the existing ones would be a potential BC break, depending on whether or not instance usage is completely eliminated.
> 
> Yes, of course. But there exist options that don’t make the API even more inconsistent than it already is. I hereby propose:
> 
> * `XMLReader::fromUrl()` as replacement for `(new XMLReader)->open()`
> * `XMLReader::fromString()` as replacement for `(new XMLReader)->xml()`
> 
> … which would make me happy. (The old, inconsistently-named, instance-and-semi-broken-static methods could be kept for BC and marked as soft-deprecated in the manual.)
> 
> —Claude 

Okay, that seems reasonable to me and I can do that.
I'll make them return static and do "new static()" like I proposed with the new static method.

For XMLWriter, I suppose we also want the static counterparts:
* `XMLWriter::toMemory()` for `(new XMLWriter)->openMemory()`
* `XMLWriter::toUri()` for `(new XMLWriter)->openUri()`

If that sounds good I'll update the RFC.

Niels