Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123401
Precedence: bulk
MIME-Version: 1.0
References: <CAEPJdu=ZTyPQ3yabhOx=rxnv5niuA+9O4BP6EsvAdkZRSS5Q2g@mail.gmail.com>
 <CAOWwgpkni4fHgZ0=AywFy=5ZrzD2o+i-xWfvK__fifo8UUQQ4w@mail.gmail.com>
In-Reply-To: <CAOWwgpkni4fHgZ0=AywFy=5ZrzD2o+i-xWfvK__fifo8UUQQ4w@mail.gmail.com>
Date: Wed, 22 May 2024 10:13:20 +0200
Message-ID: <CAEPJdukgpSiZ0CinSZH_dBS95KsG14KudD1aKFksP6X2zTLe5A@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Vote] #[\Deprecated] attribute
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009eafe80619068257"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--0000000000009eafe80619068257
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 22, 2024 at 9:33=E2=80=AFAM Nicolas Grekas <nicolas.grekas+php@=
gmail.com>
wrote:

> Hi Benjamin,
>
> The vote for the RFC #[\Deprecated] attribute is now open:
>>
>> https://wiki.php.net/rfc/deprecated_attribute
>>
>> Voting will close on Wednesday 5th June, 08:00 GMT.
>>
>
> I voted "no" because I think this is better addressed in userland, as thi=
s
> gives more flexibility.
> I would better have an attribute that is made only for static analysis
> with no runtime side effects at all.
> Being forced to make the attribute final because the implementation in th=
e
> engine requires is an example of why the engine is not the correct place =
to
> send this notice. Another example is not being able to add the attribute =
on
> classes because [engine reasons].
>

This is a misrepresentation of what this RFC is. There are no engine
reasons for not being able to set it on classes. It just has not been
implemented yet.

Allowing deprecations on classes is something that needs to be figured out
in a separate RFC in how these semantics work. Then adding Deprecated
attribute would just be a trivial matter.

You could argue about the order of things, we could have first made an RFC
for deprecated classes, but we should avoid a waterfall process of
dependencies in things to do in the language.


>
> trigger_error() is better fitted for the runtime side-effect when it's
> desired.
> In my opinion, #[Deprecated] should be only for static analysers /
> reflection (although this would need another discussion - I'm not sure th=
is
> would benefit being in the engine vs in a userland package.
>

This is the same as above, changing how deprecations work in the engine is
orthogonal to this attribute. These attributes are concerned with tagging
code elements with flags that the engine already provides, already makes
available for internal code elements.


>
> Thanks for the RFC anyway.
>
> Nicolas
>

--0000000000009eafe80619068257
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, May 22, 2024 at 9:33=E2=80=AF=
AM Nicolas Grekas &lt;<a href=3D"mailto:nicolas.grekas%2Bphp@gmail.com">nic=
olas.grekas+php@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-lef=
t-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr"><div dir=3D"ltr">Hi Benjamin,<br></div><br><div class=3D"gmail_quo=
te"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,20=
4);padding-left:1ex"><div dir=3D"ltr">The vote for the RFC #[\Deprecated] a=
ttribute=C2=A0is now open:<br><br><a href=3D"https://wiki.php.net/rfc/depre=
cated_attribute" target=3D"_blank">https://wiki.php.net/rfc/deprecated_attr=
ibute</a><br><br>Voting will close on Wednesday 5th June, 08:00 GMT.<br></d=
iv></blockquote><div><br></div><div>I voted &quot;no&quot; because I think =
this is better addressed in userland, as this gives more flexibility.</div>=
<div>I would better have an attribute that is made only for static analysis=
 with no runtime side effects at all.</div><div>Being forced to make the at=
tribute final because the implementation in the engine requires is an examp=
le of why the engine is not the correct place to send this notice. Another =
example is not being able to add the attribute on classes because [engine r=
easons].<br></div></div></div></blockquote><div><br></div><div>This is a mi=
srepresentation of what this RFC is. There are no engine reasons for not be=
ing able to set it on classes. It just has not been implemented yet.</div><=
div><br></div><div>Allowing deprecations on classes is something that needs=
 to be figured out in a separate RFC in how these semantics work. Then addi=
ng Deprecated attribute would just be a trivial matter.</div><div><br></div=
><div>You could argue about the order of things, we could have first made a=
n RFC for deprecated classes, but we should avoid a waterfall process of de=
pendencies in things to do in the language.</div><div>=C2=A0</div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-widt=
h:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-le=
ft:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div></div><div><br></d=
iv><div>trigger_error() is better fitted for the runtime side-effect when i=
t&#39;s desired.</div><div>In my opinion, #[Deprecated] should be only for =
static analysers / reflection (although this would need another discussion =
- I&#39;m not sure this would benefit being in the engine vs in a userland =
package.</div></div></div></blockquote><div><br></div><div>This is the same=
 as above, changing how deprecations work in the engine is orthogonal to th=
is attribute. These attributes are concerned with tagging code elements wit=
h flags that the engine already provides, already makes available for inter=
nal code elements.=C2=A0</div><div>=C2=A0</div><blockquote class=3D"gmail_q=
uote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-s=
tyle:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D=
"ltr"><div class=3D"gmail_quote"><div><br></div><div>Thanks for the RFC any=
way.</div><div><br></div><div>Nicolas<br></div></div></div>
</blockquote></div></div>

--0000000000009eafe80619068257--