Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123398
Precedence: bulk
MIME-Version: 1.0
References: <CAEPJdu=ZTyPQ3yabhOx=rxnv5niuA+9O4BP6EsvAdkZRSS5Q2g@mail.gmail.com>
In-Reply-To: <CAEPJdu=ZTyPQ3yabhOx=rxnv5niuA+9O4BP6EsvAdkZRSS5Q2g@mail.gmail.com>
Date: Wed, 22 May 2024 09:33:21 +0200
Message-ID: <CAOWwgpkni4fHgZ0=AywFy=5ZrzD2o+i-xWfvK__fifo8UUQQ4w@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Vote] #[\Deprecated] attribute
To: =?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?= <kontakt@beberlei.de>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a451f0061905f372"
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000a451f0061905f372
Content-Type: text/plain; charset="UTF-8"

Hi Benjamin,

The vote for the RFC #[\Deprecated] attribute is now open:
>
> https://wiki.php.net/rfc/deprecated_attribute
>
> Voting will close on Wednesday 5th June, 08:00 GMT.
>

I voted "no" because I think this is better addressed in userland, as this
gives more flexibility.
I would better have an attribute that is made only for static analysis with
no runtime side effects at all.
Being forced to make the attribute final because the implementation in the
engine requires is an example of why the engine is not the correct place to
send this notice. Another example is not being able to add the attribute on
classes because [engine reasons].

trigger_error() is better fitted for the runtime side-effect when it's
desired.
In my opinion, #[Deprecated] should be only for static analysers /
reflection (although this would need another discussion - I'm not sure this
would benefit being in the engine vs in a userland package.

Thanks for the RFC anyway.

Nicolas

--000000000000a451f0061905f372
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Benjamin,<br></div><br><div class=3D"g=
mail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"l=
tr">The vote for the RFC #[\Deprecated] attribute=C2=A0is now open:<br><br>=
<a href=3D"https://wiki.php.net/rfc/deprecated_attribute" target=3D"_blank"=
>https://wiki.php.net/rfc/deprecated_attribute</a><br><br>Voting will close=
 on Wednesday 5th June, 08:00 GMT.<br></div></blockquote><div><br></div><di=
v>I voted &quot;no&quot; because I think this is better addressed in userla=
nd, as this gives more flexibility.</div><div>I would better have an attrib=
ute that is made only for static analysis with no runtime side effects at a=
ll.</div><div>Being forced to make the attribute final because the implemen=
tation in the engine requires is an example of why the engine is not the co=
rrect place to send this notice. Another example is not being able to add t=
he attribute on classes because [engine reasons].<br></div><div><br></div><=
div>trigger_error() is better fitted for the runtime side-effect when it=
9;s desired.</div><div>In my opinion, #[Deprecated] should be only for stat=
ic analysers / reflection (although this would need another discussion - I&=
#39;m not sure this would benefit being in the engine vs in a userland pack=
age.</div><div><br></div><div>Thanks for the RFC anyway.</div><div><br></di=
v><div>Nicolas<br></div></div></div>

--000000000000a451f0061905f372--