Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123387
Content-Type: multipart/alternative; boundary=Apple-Mail-AE02AFCD-D6FA-47F1-BBA4-10AF9FA451CA
Content-Transfer-Encoding: 7bit
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}
In-Reply-To: <CAJp_myWSagrqv3uH6CNxx0qskEsq0Ds-7Srf6DwSvn+4MT8B+w@mail.gmail.com>
Cc: Niels Dossche <dossche.niels@gmail.com>,
 PHP internals <internals@lists.php.net>
Date: Tue, 21 May 2024 21:58:34 +0200
Message-ID: <721C2420-62AB-4586-AFAA-2E831C678EB5@gmail.com>
References: <CAJp_myWSagrqv3uH6CNxx0qskEsq0Ds-7Srf6DwSvn+4MT8B+w@mail.gmail.com>
To: Matthew Weier O'Phinney <mweierophinney@gmail.com>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail-AE02AFCD-D6FA-47F1-BBA4-10AF9FA451CA
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable



> Le 21 mai 2024 =C3=A0 21:00, Matthew Weier O'Phinney <mweierophinney@gmail=
.com> a =C3=A9crit :
>> (But again, I prefer that all those methods work on instances, as it was t=
he case before PHP 8. They shouldn=E2=80=99t have been switched to static-bu=
t-broken-for-subclasses without discussion.)
>=20
> Fixing the existing ones would be a potential BC break, depending on wheth=
er or not instance usage is completely eliminated.

Yes, of course. But there exist options that don=E2=80=99t make the API even=
 more inconsistent than it already is. I hereby propose:

* `XMLReader::fromUrl()` as replacement for `(new XMLReader)->open()`
* `XMLReader::fromString()` as replacement for `(new XMLReader)->xml()`

=E2=80=A6 which would make me happy. (The old, inconsistently-named, instanc=
e-and-semi-broken-static methods could be kept for BC and marked as soft-dep=
recated in the manual.)

=E2=80=94Claude=20=

--Apple-Mail-AE02AFCD-D6FA-47F1-BBA4-10AF9FA451CA
Content-Type: text/html;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div dir=3D"ltr"><meta http-equiv=3D"conten=
t-type" content=3D"text/html; charset=3Dutf-8"><div dir=3D"ltr"><meta http-e=
quiv=3D"content-type" content=3D"text/html; charset=3Dutf-8"><div dir=3D"ltr=
"><meta http-equiv=3D"content-type" content=3D"text/html; charset=3Dutf-8"><=
div dir=3D"ltr"><meta http-equiv=3D"content-type" content=3D"text/html; char=
set=3Dutf-8"><div dir=3D"ltr"></div><div dir=3D"ltr"><br></div><div dir=3D"l=
tr"><br><blockquote type=3D"cite">Le 21 mai 2024 =C3=A0 21:00, Matthew Weier=
 O'Phinney &lt;mweierophinney@gmail.com&gt; a =C3=A9crit&nbsp;:<br><br></blo=
ckquote></div><blockquote type=3D"cite"><div dir=3D"ltr"><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">(But again, I prefer that all those methods wor=
k on instances, as it was the case before PHP 8. They shouldn=E2=80=99t have=
 been switched to static-but-broken-for-subclasses without discussion.)<br><=
/blockquote><div><br></div><div>Fixing the existing ones would be a potentia=
l BC break, depending on whether or not instance usage is completely elimina=
ted.</div><div></div></div></blockquote><br><div>Yes, of course. But there e=
xist options that don=E2=80=99t make the API even more inconsistent than it a=
lready is. I hereby propose:</div><div><br></div><div>* `XMLReader::fromUrl(=
)` as replacement for `(new XMLReader)-&gt;open()`</div><div>* `XMLReader::f=
romString()` as replacement for `(new XMLReader)-&gt;xml()`</div><div><br></=
div><div>=E2=80=A6 which would make me happy. (The old, inconsistently-named=
, instance-and-semi-broken-static methods could be kept for BC and marked as=
 soft-deprecated in the manual.)</div><div><br></div><div>=E2=80=94Claude&nb=
sp;</div></div></div></div></div></body></html>=

--Apple-Mail-AE02AFCD-D6FA-47F1-BBA4-10AF9FA451CA--