Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123384
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to
 XML{Reader,Writer}
In-Reply-To: <ac54fd4f-24da-4649-ad2d-3431244d447b@gmail.com>
Date: Tue, 21 May 2024 19:56:44 +0200
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <37BF3748-4A18-4046-8CCD-4198094FE059@gmail.com>
References: <b8513546-294d-482e-bd1c-292b455e66a8@gmail.com>
 <ac54fd4f-24da-4649-ad2d-3431244d447b@gmail.com>
To: Niels Dossche <dossche.niels@gmail.com>
From: claude.pache@gmail.com (Claude Pache)



> Le 18 mai 2024 =C3=A0 01:13, Niels Dossche <dossche.niels@gmail.com> a =
=C3=A9crit :
>=20
> On 22/04/2024 20:41, Niels Dossche wrote:
>> Hi internals
>>=20
>> I'm opening the discussion for my RFC "Add openStream() to =
XML{Reader,Writer}".
>> RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams
>>=20
>> Kind regards
>> Niels
>=20
> Hi internals
>=20
> The main complaint that kept coming up in internal communication was =
the choice of instance methods instead of static methods.
> This has been brought up in this thread too.

Hi,

Now you have a complaint because of the choice of static methods instead =
of instance methods... :-)

You are introducing an inconstancy for subclasses, because:

* As noted in an earlier message, the existing open-like methods =
(XMLReader::XML() and XMLReader::open()) don=E2=80=99t work statically =
on subclasses (they create an instance of the base class, not of the =
subclass). You must use them as instance methods.

* On the other hand, the method you are going to introduce won=E2=80=99t =
work as instance method. You must use it statically.

Please, if you want to make the new method static only, fix first the =
existing ones, so that they also work statically (on subclasses).

(But again, I prefer that all those methods work on instances, as it was =
the case before PHP 8. They shouldn=E2=80=99t have been switched to =
static-but-broken-for-subclasses without discussion.)

=E2=80=94Claude=