Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123378
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqzWf5Fev==xeKnyWHqR+h7Z5se143DfEX-NW2N_AnFDPw@mail.gmail.com>
 <153b8bf3-961a-45c9-b808-a18c90d828b7@beccati.com>
In-Reply-To: <153b8bf3-961a-45c9-b808-a18c90d828b7@beccati.com>
Date: Tue, 21 May 2024 06:53:44 +0100
Message-ID: <CA+XhMqyHm6ZxEfmSfdZK=RfZq4DbBnFe-8gf=vtaZ0erKkWAtQ@mail.gmail.com>
Subject: Re: [PHP-DEV] ext/pgsql: pg_put_line deprecation proposal
To: Matteo Beccati <php@beccati.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007e961f0618f07184"
From: devnexen@gmail.com (David CARLIER)

--0000000000007e961f0618f07184
Content-Type: text/plain; charset="UTF-8"

Hi Matteo,

On Mon, 20 May 2024 at 14:08, Matteo Beccati <php@beccati.com> wrote:

> Hi,
>
> Il 20/05/2024 14:03, David CARLIER ha scritto:
> > I would like to know if it would be fine to deprecate pg_put_line
> > <http://pg_put_line>.
> >
> > Reasoning is PQPutLine is part of the obsolete list of calls for COPY
> > purpose
> > <https://www.postgresql.org/docs/current/libpq-copy.html#LIBPQ-PQPUTLINE> since
> the PostgreSQL protocol 3.0 version (supported since postgresql 7.4
> released about 20 years ago, see New client-to-server protocol regarding
> COPY <https://www.postgresql.org/docs/7.4/release-7-4.html>).
> >
> > Related PR <https://github.com/php/php-src/pull/14250>.
>
> I have fond memories of using pg_put_line several years ago!
>
> It is true that it's obsolete and although they still work, they are
> deprecated in libpq.
>
> However, I have a few remarks...
>
> If you're targeting the protocol 3.0 change, what is deprecated is the
> pg_put_line('\\.') call that needed to be sent before calling
> pg_end_copy().
>
> pg_put_line() is used to send data, not just the end message.
>
> Hence, the UPGRADING message misrepresents the reason why pg_put_line()
> is deprecated.
>
> In case we really decide to deprecate pg_put_line on the PHP side, so
> should be pg_end_copy.
>
> However we don't provide a full alternative to it, because pg_copy_from
> only accepts arrays, according to the documentation. As such, there is
> no real alternative for "streaming" data without storing it all in memory.
>

Thanks for your thoughts, I ve overlooked this.

>
> Unless we provide it, I would vote against deprecating them.
>
> My opinion could change if pg_copy_from() worked with generators, but I
> still think the two function still have a place for those needing
> low-level access.
>
>
> Cheers
> --
> Matteo Beccati
>
> Development & Consulting - http://www.beccati.com/
>

--0000000000007e961f0618f07184
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Matteo,</div><br><div class=3D"gmail_q=
uote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 20 May 2024 at 14:08, M=
atteo Beccati &lt;<a href=3D"mailto:php@beccati.com">php@beccati.com</a>&gt=
; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
Il 20/05/2024 14:03, David CARLIER ha scritto:<br>
&gt; I would like to know if it would be fine to deprecate pg_put_line <br>
&gt; &lt;<a href=3D"http://pg_put_line" rel=3D"noreferrer" target=3D"_blank=
">http://pg_put_line</a>&gt;.<br>
&gt; <br>
&gt; Reasoning is PQPutLine is part of the obsolete list=C2=A0of calls for =
COPY <br>
&gt; purpose <br>
&gt; &lt;<a href=3D"https://www.postgresql.org/docs/current/libpq-copy.html=
#LIBPQ-PQPUTLINE" rel=3D"noreferrer" target=3D"_blank">https://www.postgres=
ql.org/docs/current/libpq-copy.html#LIBPQ-PQPUTLINE</a>&gt;=C2=A0since the =
PostgreSQL protocol 3.0 version (supported since postgresql 7.4 released ab=
out 20 years ago, see New client-to-server protocol regarding COPY &lt;<a h=
ref=3D"https://www.postgresql.org/docs/7.4/release-7-4.html" rel=3D"norefer=
rer" target=3D"_blank">https://www.postgresql.org/docs/7.4/release-7-4.html=
</a>&gt;).<br>
&gt; <br>
&gt; Related PR &lt;<a href=3D"https://github.com/php/php-src/pull/14250" r=
el=3D"noreferrer" target=3D"_blank">https://github.com/php/php-src/pull/142=
50</a>&gt;.<br>
<br>
I have fond memories of using pg_put_line several years ago!<br>
<br>
It is true that it&#39;s obsolete and although they still work, they are <b=
r>
deprecated in libpq.<br>
<br>
However, I have a few remarks...<br>
<br>
If you&#39;re targeting the protocol 3.0 change, what is deprecated is the =
<br>
pg_put_line(&#39;\\.&#39;) call that needed to be sent before calling pg_en=
d_copy().<br>
<br>
pg_put_line() is used to send data, not just the end message.<br>
<br>
Hence, the UPGRADING message misrepresents the reason why pg_put_line() <br=
>
is deprecated.<br>
<br>
In case we really decide to deprecate pg_put_line on the PHP side, so <br>
should be pg_end_copy.<br>
<br>
However we don&#39;t provide a full alternative to it, because pg_copy_from=
 <br>
only accepts arrays, according to the documentation. As such, there is <br>
no real alternative for &quot;streaming&quot; data without storing it all i=
n memory.<br></blockquote><div><br></div><div>Thanks for your thoughts, I v=
e overlooked this.=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">
<br>
Unless we provide it, I would vote against deprecating them.<br>
<br>
My opinion could change if pg_copy_from() worked with generators, but I <br=
>
still think the two function still have a place for those needing <br>
low-level access.<br>
<br>
<br>
Cheers<br>
-- <br>
Matteo Beccati<br>
<br>
Development &amp; Consulting - <a href=3D"http://www.beccati.com/" rel=3D"n=
oreferrer" target=3D"_blank">http://www.beccati.com/</a><br>
</blockquote></div></div>

--0000000000007e961f0618f07184--