Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123353
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-456-gcd147058c-fm-hotfix-20240509.001-g0aad06e4
Precedence: bulk
MIME-Version: 1.0
Message-ID: <864f67fb-01a5-49a6-9f81-b54600046652@app.fastmail.com>
In-Reply-To: <407efbd0-2d9c-4bcb-b795-0ee326728415@heigl.org>
References: 
 <CAPzBOBMpOztgNQx35ZnP4c5ZHV-Ax1ETH0=YMzVT9Hq9cdyyDQ@mail.gmail.com>
 <407efbd0-2d9c-4bcb-b795-0ee326728415@heigl.org>
Date: Sat, 18 May 2024 11:43:58 -0500
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [Discussion] "Internal" attribute and warning
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Sat, May 18, 2024, at 11:06 AM, Andreas Heigl wrote:
> Hey all.
>
> Am 18.05.24 um 16:00 schrieb Robert Landers:
>> Hello internals,
>> 
>> I've been thinking about having an "internal" attribute that will emit
>> a warning if called from outside it's left-most namespace.
>> 
>> It might look something like this:
>> 
>> namespace MyCompany\PackageA {
>>    #[\Internal] function doStuff() {}
>> }

*snip*

I think an important question to answer here is what we want to have as our definition of "package".

1. Should the package be defined by the namespace? If so, anyone can put code into any namespace; it's not even hard to add to someone else's namespace.
2. Should the package be implicit, or explicit?  If it's a namespace, is it auto-implicit or an "empty" package?
3. Should package be defined/implied by the file system, like many languages?  Then we'd need a way to define/declare a package on the file system.  (I have some thoughts there.)  But that may run into performance issues, though they could be solved by opcache.  This could also make it harder to inject code into someone else's namespace.  (Whether that's good or bad is a matter of opinion.)

The proposed attribute would be going with point 2, implicitly.  That may be a useful approach, I don't know, but it's not something we should do "implicitly", lest it cause issues for us in the future.

--Larry Garfield