Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123341
Message-ID: <ac54fd4f-24da-4649-ad2d-3431244d447b@gmail.com>
Date: Sat, 18 May 2024 01:13:25 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: [PHP-DEV] Re: [RFC] [Discussion] Add openStream() to XML{Reader,Writer}
To: PHP internals <internals@lists.php.net>
References: <b8513546-294d-482e-bd1c-292b455e66a8@gmail.com>
Content-Language: en-US
In-Reply-To: <b8513546-294d-482e-bd1c-292b455e66a8@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
From: dossche.niels@gmail.com (Niels Dossche)

On 22/04/2024 20:41, Niels Dossche wrote:
> Hi internals
> 
> I'm opening the discussion for my RFC "Add openStream() to XML{Reader,Writer}".
> RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams
> 
> Kind regards
> Niels

Hi internals

The main complaint that kept coming up in internal communication was the choice of instance methods instead of static methods.
This has been brought up in this thread too.

I switched back to using static methods, and they're now called XMLReader::fromStream($stream) and XMLWriter::toStream($stream).
They return the static type, which means that they'll be compatible with child classes that inherit from XML{Reader,Writer}.
The child constructor will in that case be called with no arguments (i.e. it'll do `new static()` internally).

The RFC text has been updated to reflect this change. New RFC text version is 0.10.0.

Kind regards
Niels