Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123333
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-456-gcd147058c-fm-hotfix-20240509.001-g0aad06e4
Precedence: bulk
MIME-Version: 1.0
Message-ID: <8432541c-ad13-4682-9034-bcfe47e142ff@app.fastmail.com>
In-Reply-To: 
 <CAEPJdunbcKzcU1X34tj5gseahR4ubfSiL6S1wBp1xQv1i6ULqg@mail.gmail.com>
References: 
 <CAEPJdumvJNQ+JZ3wkLP-Q2O0y57g=W_hHFkuvOKMVJqqraKCzw@mail.gmail.com>
 <CAEPJdunbcKzcU1X34tj5gseahR4ubfSiL6S1wBp1xQv1i6ULqg@mail.gmail.com>
Date: Fri, 17 May 2024 15:02:27 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Fri, May 17, 2024, at 9:53 AM, Benjamin Au=C3=9Fenhofer wrote:
> On Tue, Apr 23, 2024 at 3:27=E2=80=AFPM Benjamin Au=C3=9Fenhofer <kont=
akt@beberlei.de> wrote:
>> Hi internals,
>>=20
>> My PR for #[\Deprecated] attribute was in hibernation for a long whil=
e now and after some off-list discussion a few weeks ago I have decided =
to revisit it and asked Tim to help me out with the work.
>>=20
>> Tim has cleaned up the PR quite a bit and also worked in additional f=
eatures such as #[Deprecated] support in stub generation.
>>=20
>> While there are still some small todos, at this point we want to rest=
art the discussion about the RFC for inclusion in 8.4:
>>=20
>> RFC: https://wiki.php.net/rfc/deprecated_attribute
>> PR: https://github.com/php/php-src/pull/11293
>> Old discussion: https://externals.io/message/112554#112554
>>=20
>> Let me know about your questions and feedback.
>
> Feedback period is now nearing 4 weeks and the last 2 have not brought=20
> any new significant discussions, as such we plan to open the vote next=20
> Wednesday if no new roadblocks come up.
>
> Thank you to all participants for the feedback.=20
>>=20
>> greetings
>> Benjamin

Why is the attribute not allowed on classes?  I think it would make sens=
e on every language structure, unrestricted.  (Including classes, parame=
ters, everything.)

The user-space definition of the attribute is invalid in the example: It=
 declares properties AND promoted constructor args.  That can/should be =
combined.

Otherwise, this looks good to me.

--Larry Garfield