Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123315
Precedence: bulk
MIME-Version: 1.0
References: <CAEPJdumvJNQ+JZ3wkLP-Q2O0y57g=W_hHFkuvOKMVJqqraKCzw@mail.gmail.com>
 <CAEPJduku=Sdptw4zDDgTHzZ7SW0KDFHaoF5op5vjLAXk9344Vw@mail.gmail.com>
In-Reply-To: <CAEPJduku=Sdptw4zDDgTHzZ7SW0KDFHaoF5op5vjLAXk9344Vw@mail.gmail.com>
Date: Tue, 14 May 2024 09:00:38 +0200
Message-ID: <CAEPJdumhfztTWHC72+x0Nry0XXci2EsVrMAtmoXH4bNONWG3sw@mail.gmail.com>
Subject: [PHP-DEV] Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3
To: PHP Internals <internals@lists.php.net>
Cc: "tim@tideways-gmbh.com" <tim@tideways-gmbh.com>
Content-Type: multipart/alternative; boundary="000000000000dd7a620618648f55"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--000000000000dd7a620618648f55
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 2, 2024 at 1:00=E2=80=AFPM Benjamin Au=C3=9Fenhofer <kontakt@be=
berlei.de>
wrote:

>
>
> On Tue, Apr 23, 2024 at 3:27=E2=80=AFPM Benjamin Au=C3=9Fenhofer <kontakt=
@beberlei.de>
> wrote:
>
>> Hi internals,
>>
>> My PR for #[\Deprecated] attribute was in hibernation for a long while
>> now and after some off-list discussion a few weeks ago I have decided to
>> revisit it and asked Tim to help me out with the work.
>>
>> Tim has cleaned up the PR quite a bit and also worked in additional
>> features such as #[Deprecated] support in stub generation.
>>
>> While there are still some small todos, at this point we want to restart
>> the discussion about the RFC for inclusion in 8.4:
>>
>> RFC: https://wiki.php.net/rfc/deprecated_attribute
>> PR: https://github.com/php/php-src/pull/11293
>> Old discussion: https://externals.io/message/112554#112554
>>
>> Let me know about your questions and feedback.
>>
>> greetings
>> Benjamin
>>
>
> We have updated the RFC and PR to include #[Deprecated] on class constant=
s
> and enum cases as this is something the engine already supports for
> internal class constants.
>
> This does not include support for non-class based constants, because they
> don't have support for attributes at the moment and also only recently go=
t
> reflection support (for 8.4).
>
> We are planning to work on adding $since next and get back to the list
> once that is finished.
>

The $since implementation is now added to the RFC and to the PR.

We decided to make this a secondary voting choice, while there are
use-cases for it in php core for doc rendering, other ways of doing the
same thing are also available and given userland frameworks stated
different requirements maybe its better left for userland to implement.

--000000000000dd7a620618648f55
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, May 2, 2024 at 1:00=E2=80=AFP=
M Benjamin Au=C3=9Fenhofer &lt;<a href=3D"mailto:kontakt@beberlei.de">konta=
kt@beberlei.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:sol=
id;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><d=
iv dir=3D"ltr"><br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" cl=
ass=3D"gmail_attr">On Tue, Apr 23, 2024 at 3:27=E2=80=AFPM Benjamin Au=C3=
=9Fenhofer &lt;<a href=3D"mailto:kontakt@beberlei.de" target=3D"_blank">kon=
takt@beberlei.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:s=
olid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">=
Hi internals,<div><br></div><div>My PR for #[\Deprecated] attribute was in =
hibernation for a long while now and after some off-list discussion a few w=
eeks ago I have decided to revisit it and asked Tim to help me out with the=
 work.</div><div><br></div><div>Tim has cleaned up the PR quite a bit and a=
lso worked in additional features such as #[Deprecated] support in stub gen=
eration.</div><div><br></div><div>While there are still some small todos, a=
t this point we want to restart the discussion about the RFC for inclusion =
in 8.4:</div><div><br></div><div>RFC: <a href=3D"https://wiki.php.net/rfc/d=
eprecated_attribute" target=3D"_blank">https://wiki.php.net/rfc/deprecated_=
attribute</a><br></div><div>PR: <a href=3D"https://github.com/php/php-src/p=
ull/11293" target=3D"_blank">https://github.com/php/php-src/pull/11293</a><=
br></div><div>Old discussion:=C2=A0<a href=3D"https://externals.io/message/=
112554#112554" target=3D"_blank">https://externals.io/message/112554#112554=
</a></div><div><br></div><div>Let me know about your questions and feedback=
.</div><div><br></div><div>greetings</div><div>Benjamin</div></div></blockq=
uote><div><br></div><div>We have updated the RFC and PR to include #[Deprec=
ated] on class constants and enum cases as this is something the engine alr=
eady supports for internal class constants.=C2=A0</div><div><br></div><div>=
This does not include support for non-class based constants, because they d=
on&#39;t have support for attributes at the moment and also only recently g=
ot reflection support (for 8.4).</div><div><br></div><div>We are planning t=
o work on adding $since next and get back to the list once that is finished=
.</div></div></div></blockquote><div><br></div><div>The $since implementati=
on is now added to the RFC and to the PR.</div><div><br></div><div>We decid=
ed to make this a secondary voting choice, while there are use-cases for it=
 in php core for doc rendering, other ways of doing the same thing are also=
 available and given userland frameworks stated different requirements mayb=
e its better left for userland to implement.</div><div><br></div><div><br><=
/div><div><br></div><div><br></div><div>=C2=A0</div></div></div>

--000000000000dd7a620618648f55--