Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123304
Message-ID: <b7592547-6ce5-499f-a0c0-96c0457ae624@gmail.com>
Date: Fri, 10 May 2024 19:38:44 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Add openStream() to
 XML{Reader,Writer}
To: php internals <internals@lists.php.net>
References: <b8513546-294d-482e-bd1c-292b455e66a8@gmail.com>
 <db382d5c-7774-4929-8234-f7b24ce1247f@gmail.com>
 <b5c68b99-cd04-4f91-a03e-f2b6fb74ae1c@app.fastmail.com>
Content-Language: en-US
In-Reply-To: <b5c68b99-cd04-4f91-a03e-f2b6fb74ae1c@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
From: dossche.niels@gmail.com (Niels Dossche)

On 10/05/2024 16:31, Larry Garfield wrote:
> On Fri, May 10, 2024, at 2:03 PM, Niels Dossche wrote:
>> On 22/04/2024 20:41, Niels Dossche wrote:
>>> Hi internals
>>>
>>> I'm opening the discussion for my RFC "Add openStream() to XML{Reader,Writer}".
>>> RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams
>>>
>>> Kind regards
>>> Niels
>>
>> Hi internals
>>
>> It's been over two weeks since I opened the discussion.
>> Please raise any last concerns now.
>> I'd like to start voting next week Monday.
>>
>> Kind regards
>> Niels
> 
> Please include some examples of what a full usage would look like with the new additions.  I'm not super experienced with those libraries right now, but the "create the object, THEN populate it with its data source" pattern feels very weird to me.  (Though at least it's consistent now rather than as it was before, thanks.)
> 
> --Larry Garfield

Hi Larry

I added minimal examples for both.
The streams I used are just the memory and output streams for simplicity so that it can be tested on its own.

Kind regards
Niels