Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123302
Message-ID: <d02ba553-3c0a-4264-ab49-9b0536fe157a@bastelstu.be>
Date: Fri, 10 May 2024 18:31:34 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Transform exit() from a language construct into a
 standard function
To: internals@lists.php.net
References: <GUMp_LJKefk4aLz9P9MA-zonKuik6uUNWZTtOAx-IeIhjPFsgfT3HHECPpyGF_ujq-LxI6tzBxMYgL5CMVGRkyzxSugweKix_YUGo2rXnb4=@gpb.moe>
 <98b2b3c7-9fc7-4832-8b70-93c432b334eb@app.fastmail.com>
Content-Language: en-US
In-Reply-To: <98b2b3c7-9fc7-4832-8b70-93c432b334eb@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 5/9/24 16:27, Larry Garfield wrote:
> I support this.  My only question (which applies to current exit() as well), is what the exit code is when you pass a string as the parameter.  That's not clear from the exit() docs currently, but the RFC made me wonder.  (This may be just a doc fix and we move on with life.)
> 

If a string is passed, the exit_status is left untouched [1]. In 
practice this should always result in an exit status of 0, because I 
can't see how the exit_status would be non-zero before `exit("foo");` 
successfully executes.

Best regards
Tim Düsterhus

[1] 
https://github.com/php/php-src/blob/f88fc9c6e8262fe48eb9cf078e32e63af19047f2/Zend/zend_vm_def.h#L7541-L7570