Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123284
Date: Thu, 9 May 2024 14:51:33 +0100 (BST)
To: Matteo Beccati <php@beccati.com>
cc: "internals@lists.php.net" <internals@lists.php.net>, 
    Saki Takamachi <saki@sakiot.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers
In-Reply-To: <cd461f13-9d39-4720-a00e-df448da0c30e@beccati.com>
Message-ID: <3d0bd45f-c6ba-69f6-6afe-0a08c94f471d@php.net>
References: <ff5785b8-ba73-4302-9e1a-afaba34650bb@beccati.com> <00079548-1799-4215-8F73-EFDCD795532F@sakiot.com> <098996d6-32e4-460c-a82a-aeef3b7e61d3@beccati.com> <9A6577BD-3BC5-41E1-965D-4B30D16CDB3D@sakiot.com> <e7cdbbcb-3d1d-4d43-b592-61af47fee7b0@beccati.com>
 <444757f0-78c8-41e1-aaa1-70ad4016d813@beccati.com> <cd461f13-9d39-4720-a00e-df448da0c30e@beccati.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1638891265-1715262695=:3952"
From: derick@php.net (Derick Rethans)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1638891265-1715262695=:3952
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 9 May 2024, Matteo Beccati wrote:

> Il 03/05/2024 11:14, Matteo Beccati ha scritto:
> >=20
> > I've updated once again the RFC and implemented most of the 3 major=20
> > dialects (mysql, pgsql, sqlite) in the drivers.
> >=20
> > https://wiki.php.net/rfc/pdo_driver_specific_parsers
> >=20
> > https://github.com/php/php-src/pull/14035
> >=20
> > I've tried to keep syntax changes we might not want as separate commits=
 in
> > the PR.
> >=20
> > For example:
> >  =C2=A0- the pdo_pgsql driver now also understands C-style escape strin=
gs and
> > dollar quoted strings.
> >  =C2=A0- pdo_sqlite supports Access-style [identifiers].
> >  =C2=A0- pdo_mysql will consider "--" a comment only when followed by w=
hitespace.
> >=20
> > The latter has been a particular challenge for me and I've been able to
> > overcome it by using the re2c:eof feature, which I then discovered bein=
g
> > available only in a later version compared to our requirements (1.2.1,
> > released Aug 2019). As is, the Windows build fails on GH because the sd=
k
> > ships with 1.1.1.
> >=20
> > Perhaps someone with better re2c knowledge can get it working with re2c
> > 1.0.3+, or perhaps it's not really worth it.
> >=20
> > Looking forward to hearing from you!
>=20
> I didn't see this sparking up discussion, so it either went unnoticed, or
> everybody is fine with it (even the re2c version bump) ;-)

I left a comment about that:
https://github.com/php/php-src/pull/14035#pullrequestreview-2047992559

> In any case I'm planning to start the vote in about 2 weeks from now.=20
> Next week I'll be organising phpday in Verona, so feel free to=20
> approach me if you are around and have any questions.
>=20
> I might even try go get out of my comfort zone and do a lightning talk=20
> on the topic. That would be a first in 20+ years of conference=20
> organisation... we'll see!

That'd be handy. I'll see you there :-)

cheers,
Derick
--8323329-1638891265-1715262695=:3952--