Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123279
Feedback-ID: i6f4c46c2:Fastmail
Message-ID: <cd461f13-9d39-4720-a00e-df448da0c30e@beccati.com>
Date: Thu, 9 May 2024 11:26:48 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers
To: "internals@lists.php.net" <internals@lists.php.net>
Cc: Saki Takamachi <saki@sakiot.com>
References: <ff5785b8-ba73-4302-9e1a-afaba34650bb@beccati.com>
 <00079548-1799-4215-8F73-EFDCD795532F@sakiot.com>
 <098996d6-32e4-460c-a82a-aeef3b7e61d3@beccati.com>
 <9A6577BD-3BC5-41E1-965D-4B30D16CDB3D@sakiot.com>
 <e7cdbbcb-3d1d-4d43-b592-61af47fee7b0@beccati.com>
 <444757f0-78c8-41e1-aaa1-70ad4016d813@beccati.com>
Content-Language: en-GB
In-Reply-To: <444757f0-78c8-41e1-aaa1-70ad4016d813@beccati.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: php@beccati.com (Matteo Beccati)

Hi,

Il 03/05/2024 11:14, Matteo Beccati ha scritto:
> Hi internals!
> 
> I've updated once again the RFC and implemented most of the 3 major 
> dialects (mysql, pgsql, sqlite) in the drivers.
> 
> https://wiki.php.net/rfc/pdo_driver_specific_parsers
> 
> https://github.com/php/php-src/pull/14035
> 
> I've tried to keep syntax changes we might not want as separate commits 
> in the PR.
> 
> For example:
>   - the pdo_pgsql driver now also understands C-style escape strings and 
> dollar quoted strings.
>   - pdo_sqlite supports Access-style [identifiers].
>   - pdo_mysql will consider "--" a comment only when followed by 
> whitespace.
> 
> The latter has been a particular challenge for me and I've been able to 
> overcome it by using the re2c:eof feature, which I then discovered being 
> available only in a later version compared to our requirements (1.2.1, 
> released Aug 2019). As is, the Windows build fails on GH because the sdk 
> ships with 1.1.1.
> 
> Perhaps someone with better re2c knowledge can get it working with re2c 
> 1.0.3+, or perhaps it's not really worth it.
> 
> Looking forward to hearing from you!

I didn't see this sparking up discussion, so it either went unnoticed, 
or everybody is fine with it (even the re2c version bump) ;-)

In any case I'm planning to start the vote in about 2 weeks from now. 
Next week I'll be organising phpday in Verona, so feel free to approach 
me if you are around and have any questions.

I might even try go get out of my comfort zone and do a lightning talk 
on the topic. That would be a first in 20+ years of conference 
organisation... we'll see!


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/