Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123271
Date: Tue, 07 May 2024 14:01:24 +0000
To: Saki Takamachi <saki@sakiot.com>
Cc: php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [vote] Support object type in BCMath
Message-ID: <6Kx-yDO_RoWi8qV0NDhpziE5VX-cDF3g5RCEUjqh5iOnM2x2pWtYPz0j3bNUz-BdkkIVXXG38tu8fP9FuAiQYl2oDcTYAUivNn63B10Vw9I=@gpb.moe>
In-Reply-To: <58283467-CABC-4868-A691-A52228C5296F@sakiot.com>
References: <58283467-CABC-4868-A691-A52228C5296F@sakiot.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Wednesday, 1 May 2024 at 09:55, Saki Takamachi <saki@sakiot.com> wrote:

> Hi all!
>=20
> Voting for RFC: Support object type in BCMath has started. Voting ends on=
 2024-05-16 00:00 GMT.
> https://wiki.php.net/rfc/support_object_type_in_bcmath
>=20
> Regards,
>=20
> Saki

I voted in favour, as Number being its own type should improve DX and perfo=
rmance for small numbers as we can just store two 64bit integer, one for th=
e integral and another for the fractional part.
However, I have some remarks and questions.
Apologies if these were already brought up, but I haven't gone through the =
whole 100 long email thread.

- The comparison method should either be called "cmp", or "compare" to alig=
n with other extensions, the BC Math function being called bc_comp is weird=
.
- I don't understand why we are exposing lt, lte, gt, and gte what is the r=
ationale here? Also, the naming is kinda terrible IMHO.
- The "powmod" method should probably be called "powMod"
- Are the existing BCMath function going to be adapted to handle the new Nu=
mber object or not?
- What is the behaviour when casting a Number object to bool? Does it alway=
s cast to true like a "standard" object, or does a Number equal to 0 cast t=
o false?
- Considering the property hook RFC has been accepted, should the $value pr=
operty be a "virtual" property or not?

Best regards,

Gina P. Banyard