Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123270
Message-ID: <49aa8581-ed2e-4aa3-b330-7cd5d8efa764@wcflabs.de>
Date: Mon, 6 May 2024 20:44:12 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
To: PHP internals <internals@lists.php.net>
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
 <CAAKU0ukwfF+D5L+23BEqL053ktCp5AQOjRGdha-8pXN-yf1HBQ@mail.gmail.com>
 <06373f2b-5de0-4582-96c5-29c3b474c01d@wcflabs.de>
 <45e6365b-4963-4969-8cc1-80bae6922fc8@wcflabs.de>
 <60bb55a5-16c9-4df0-8521-75f82d3dbf5b@app.fastmail.com>
 <41ad56d9-8b27-420e-ba85-a3e9a6122bcf@wcflabs.de>
 <7a77288e-ddb7-436e-8981-b8b2508e1547@app.fastmail.com>
Content-Language: de-DE
In-Reply-To: <7a77288e-ddb7-436e-8981-b8b2508e1547@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: josh@wcflabs.de ("=?UTF-8?Q?Joshua_R=C3=BCsweg?=")

Hi

On 02.05.24 15:27, Larry Garfield wrote:
> It's not just that it errors confusingly.  It's that the design as is would be incompatible with any C-based function.  A function that works with anything *except* the standard library seems... problematic.
> 
> It's possible that, since these new functions are C-based, we could do some extra detection to see if the function is unary or not, and pass only the value if it is.  I don't know if that is possible to do performantly in C, but it's definitely more of an option than if they were in user-space.  (Again, I don't know if this is the best solution, but it seems like a possible solution.)

I definitely get your point. However, there are not many standard 
functions that can be used there. The only functions I can think of that 
can be used there are `is_*` and maybe `strlen` (which has not a bool 
return type).
I don't think that any internal functions are realistically passed 
there, but rather user-defined ones. I would therefore not make the 
function any more complicated than it already is. If the function works 
differently with internal functions than with user functions, this can 
also be very confusing for users.

Your suggestion in particular doesn't really solve the problem. This is 
because the problem would still exist with the intval function, for 
example. Two parameters are then also passed there, although the second 
one makes little to no sense there. And to decide for each function 
whether it makes sense or not …

The error message that too many parameters are passed is clear enough in 
my opinion. This is something that developers have to learn once (like 
many other things) and then the problem is solved. And even better, the 
problem is detected beforehand by a static analysis tool.

Cheers

Josh