Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123267
Date: Sat, 04 May 2024 12:31:22 +0000
To: Derick Rethans <derick@php.net>
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function
Message-ID: <89FBdQLFoPeFTpM_oW8b66OxnmqHwtV3fuD_zYXkmzxGZRR5WXOfsxPN6JEITl2kKXXAwM8viekTx3uiE7xdiTgpIgFDqXzWuNZ54mC0w0k=@gpb.moe>
In-Reply-To: <5b7ac8bb-6f88-a7e2-ac7e-f57b0970a5ba@php.net>
References: <88ea5de8-22ea-4c23-b570-229acd546c10@app.fastmail.com> <28215C90-191D-4159-9C47-86D03B9A683D@php.net> <63GXg3pF4DIRrXn-zuvO46emeZTrmkMOuiLUFwDA18PdV0y8BNqFvwidOxktGf3Z8geBiwCksbQ-Jpzg9OaxPv6VxDJRDkWCE5S2kabhmF4=@gpb.moe> <5b7ac8bb-6f88-a7e2-ac7e-f57b0970a5ba@php.net>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Friday, 3 May 2024 at 16:47, Derick Rethans <derick@php.net> wrote:

> On Fri, 3 May 2024, Gina P. Banyard wrote:
>=20
> > On Thursday, 2 May 2024 at 21:33, Derick Rethans derick@php.net wrote:
> >=20
> > > On 2 May 2024 13:48:36 BST, Ollie Read php@ollie.codes wrote:
> > >=20
> > > > These methods accept an integer to retrieve a parameter by its
> > > > position, or a string to retrieve by its name. So far, I have
> > > > built this so that if you required the first parameter, it's
> > > > parameter 0. I treat it this way because the only other place
> > > > where we deal with parameter indexes, is
> > > > ReflectionFunctionAbstract::getParameters() which returns the
> > > > parameters zero-indexed.
> > > >=20
> > > > The question that is holding this PR back is should these methods
> > > > be 1 indexed, so that the provided position is consistent with the
> > > > error messages, or how a person would typically count, or should
> > > > they be 0 indexed to remain consistent with the existing API.
> > >=20
> > > 0-indexed, as that's what PHP does everywhere else.
> >=20
> > Well not really, if you have an error (TypeError or ValueError) which
> > indicate what parameter is the problem, it will be 1-indexed.
>=20
>=20
> Which API in PHP is 1-indexed?
>=20
> cheers,
> Derick

I have given the 1-index API which is ob_get_level() in my email reply, so =
I'm confused by the question here.
ob_get_level() starts at 1 for the 1st level and increases from there. If t=
he function returns 0 then output buffering is disabled.

However, if you retrieve the full statuses of output handlers via ob_get_st=
atus() it returns a 0-index array.
So to get the correspondence between the output buffer from ob_get_level() =
and ob_get_status() you need to do +/- 1 with the indexes/levels.

I am just pointing out that such a difference in APIs already exists *withi=
n* PHP.

Like I said earlier, I don't frankly care *what* the consensus is, but cons=
idering it was split *within* the reviewers of the PR it needed to be broug=
ht to the attention of internals.
I find 0-indexing in this case utterly confusing, but that's possibly just =
me.
And if most people are in favour of 0-indexing, then let it be 0-indexing.


Best regards,

Gina P. Banyard