Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123259
Message-ID: <F6380B60-42F2-4C09-A2B6-E63C3594D537@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_54912002-73C4-4827-830A-FCE9D2342A13"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PHP-DEV] Inconsistencies between parameter number and index when
 reflecting a method/function
Date: Fri, 3 May 2024 08:50:36 +0200
In-Reply-To: <88ea5de8-22ea-4c23-b570-229acd546c10@app.fastmail.com>
Cc: =?utf-8?Q?Bj=C3=B6rn_Larsson?= <internals@lists.php.net>
To: Ollie Read <php@ollie.codes>
References: <88ea5de8-22ea-4c23-b570-229acd546c10@app.fastmail.com>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail=_54912002-73C4-4827-830A-FCE9D2342A13
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 2 mai 2024 =C3=A0 14:48, Ollie Read <php@ollie.codes> a =C3=A9crit =
:
>=20
> The question that is holding this PR back is should these methods be 1 =
indexed, so that the provided position is consistent with the error =
messages, or how a person would typically count, or should they be 0 =
indexed to remain consistent with the existing API.
>=20

It ought to be consistent with the existing reciprocal method =
`ReflectionParameter::getPosition()`, which returns `0` for parameter =
#1.

=E2=80=94Claude=

--Apple-Mail=_54912002-73C4-4827-830A-FCE9D2342A13
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;"><br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>Le 2 mai 2024 =C3=A0 14:48, Ollie Read =
&lt;php@ollie.codes&gt; a =C3=A9crit :</div><br =
class=3D"Apple-interchange-newline"><div><div style=3D"caret-color: =
rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;">The question that is holding this PR back is =
should these methods be 1 indexed, so that the provided position is =
consistent with the error messages, or how a person would typically =
count, or should they be 0 indexed to remain consistent with the =
existing API.<br></div><br =
class=3D"Apple-interchange-newline"></div></blockquote></div><br><div>It =
ought to be consistent with the existing reciprocal method =
`ReflectionParameter::getPosition()`, which returns `0` for parameter =
#1.</div><div><br></div><div>=E2=80=94Claude</div></body></html>=

--Apple-Mail=_54912002-73C4-4827-830A-FCE9D2342A13--