Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123258
Precedence: bulk
MIME-Version: 1.0
References: <88ea5de8-22ea-4c23-b570-229acd546c10@app.fastmail.com>
 <28215C90-191D-4159-9C47-86D03B9A683D@php.net> <63GXg3pF4DIRrXn-zuvO46emeZTrmkMOuiLUFwDA18PdV0y8BNqFvwidOxktGf3Z8geBiwCksbQ-Jpzg9OaxPv6VxDJRDkWCE5S2kabhmF4=@gpb.moe>
In-Reply-To: <63GXg3pF4DIRrXn-zuvO46emeZTrmkMOuiLUFwDA18PdV0y8BNqFvwidOxktGf3Z8geBiwCksbQ-Jpzg9OaxPv6VxDJRDkWCE5S2kabhmF4=@gpb.moe>
Date: Fri, 3 May 2024 08:46:38 +0200
Message-ID: <CAPzBOBPBNf6uNebijt56D2y8B=-TeEkEtf_n6BWfMa1MyU4-Dw@mail.gmail.com>
Subject: Re: [PHP-DEV] Inconsistencies between parameter number and index when
 reflecting a method/function
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: Derick Rethans <derick@php.net>, internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: landers.robert@gmail.com (Robert Landers)

On Fri, May 3, 2024 at 4:01=E2=80=AFAM Gina P. Banyard <internals@gpb.moe> =
wrote:
>
> On Thursday, 2 May 2024 at 21:33, Derick Rethans <derick@php.net> wrote:
>
> > On 2 May 2024 13:48:36 BST, Ollie Read php@ollie.codes wrote:
> >
> > > These methods accept an integer to retrieve a parameter by its positi=
on, or a string to retrieve by its name. So far, I have built this so that =
if you required the first parameter, it's parameter 0. I treat it this way =
because the only other place where we deal with parameter indexes, is Refle=
ctionFunctionAbstract::getParameters() which returns the parameters zero-in=
dexed.
> > >
> > > The question that is holding this PR back is should these methods be =
1 indexed, so that the provided position is consistent with the error messa=
ges, or how a person would typically count, or should they be 0 indexed to =
remain consistent with the existing API.
> >
> >
> > 0-indexed, as that's what PHP does everywhere else.
> >
> > cheers
> > Derick
>
> Well not really, if you have an error (TypeError or ValueError) which ind=
icate what parameter is the problem, it will be 1-indexed.
>
> Which, for me, makes it more logical to have it 1-indexed.
> If the ReflectionFunctionAbstract::getParameters() API did not exist, thi=
s is what I would have pushed for.
>
> Moreover, PHP already has a 1-indexed and 0-indexed discrepancy with the =
ob_get_level() and ob_get_status() functions.
>
> In the end, I don't really care what we choose, but this just needed clar=
ification from internals on how to proceed.
>
> Best regards,
>
> Gina P. Banyard

There's no discrepancy with ob_get_level and ob_get_status.
ob_get_level starts at 0 (no ob) and ob_get_status is count(0) with
no_ob.

count(ob_get_status(true)) =3D=3D=3D ob_get_level()

Robert Landers
Software Engineer
Utrecht NL